Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename dangling index APIs #58266

Merged

Conversation

pugnascotia
Copy link
Contributor

The dangling_indices.import API name could cause issues in the client
libs because import is a reserved word in many languages. Rename the
API to avoid this, and rename the other APIs for consistency.

Related to #48366.

The `dangling_indices.import` API name could cause issues in the client
libs because `import` is a reserved word in many languages. Rename the
API to avoid this, and rename the other APIs for consistency.
@pugnascotia pugnascotia added :Distributed Indexing/Recovery Anything around constructing a new shard, either from a local or a remote source. >refactoring v8.0.0 v7.9.0 labels Jun 17, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (:Distributed/Recovery)

@elasticmachine elasticmachine added the Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. label Jun 17, 2020
Copy link
Contributor

@sethmlarson sethmlarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from a language perspective, thanks!

Copy link
Contributor

@DaveCTurner DaveCTurner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM2

@pugnascotia pugnascotia merged commit 1f6c953 into elastic:master Jun 18, 2020
@pugnascotia pugnascotia deleted the rename-dangling-index-import-api branch June 18, 2020 07:57
pugnascotia added a commit that referenced this pull request Jun 18, 2020
The dangling_indices.import API name could cause issues in the client
libs because import is a reserved word in many languages. Rename the
API to avoid this, and rename the other APIs for consistency.

Related to #48366.
@pugnascotia
Copy link
Contributor Author

Backported to 7.x in e065d6c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Distributed Indexing/Recovery Anything around constructing a new shard, either from a local or a remote source. >refactoring Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. v7.9.0 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants