-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename dangling index APIs #58266
Merged
pugnascotia
merged 2 commits into
elastic:master
from
pugnascotia:rename-dangling-index-import-api
Jun 18, 2020
Merged
Rename dangling index APIs #58266
pugnascotia
merged 2 commits into
elastic:master
from
pugnascotia:rename-dangling-index-import-api
Jun 18, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `dangling_indices.import` API name could cause issues in the client libs because `import` is a reserved word in many languages. Rename the API to avoid this, and rename the other APIs for consistency.
pugnascotia
added
:Distributed Indexing/Recovery
Anything around constructing a new shard, either from a local or a remote source.
>refactoring
v8.0.0
v7.9.0
labels
Jun 17, 2020
Pinging @elastic/es-distributed (:Distributed/Recovery) |
elasticmachine
added
the
Team:Distributed (Obsolete)
Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination.
label
Jun 17, 2020
sethmlarson
approved these changes
Jun 17, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM from a language perspective, thanks!
DaveCTurner
approved these changes
Jun 17, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM2
pugnascotia
added a commit
that referenced
this pull request
Jun 18, 2020
The dangling_indices.import API name could cause issues in the client libs because import is a reserved word in many languages. Rename the API to avoid this, and rename the other APIs for consistency. Related to #48366.
Backported to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
:Distributed Indexing/Recovery
Anything around constructing a new shard, either from a local or a remote source.
>refactoring
Team:Distributed (Obsolete)
Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination.
v7.9.0
v8.0.0-alpha1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
dangling_indices.import
API name could cause issues in the clientlibs because
import
is a reserved word in many languages. Rename theAPI to avoid this, and rename the other APIs for consistency.
Related to #48366.