Detect noop of update index settings #61348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnhatn
added
>enhancement
:Distributed Indexing/Distributed
|
Pinging @elastic/es-distributed (:Distributed/Distributed) |
elasticmachine
added
the
Team:Distributed (Obsolete)
dnhatn
changed the title
henningandersen
approved these changes
Aug 20, 2020
server/src/internalClusterTest/java/org/elasticsearch/indices/settings/UpdateSettingsIT.java
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/cluster/metadata/MetadataUpdateSettingsService.java
Outdated
Show resolved
Hide resolved
|
run elasticsearch-ci/packaging-sample-windows |
dnhatn
added
:Distributed Indexing/CCR
|
Thanks Henning! |
dnhatn
added a commit
that referenced
this pull request
Aug 24, 2020
This optimization is more relevant in the context of CCR. When a node in the follower cluster leaves, we reallocate the shard-follow tasks on that node to other nodes. The new tasks will overwhelm the follower cluster with many put-mapping, update-settings requests, although most of them are noop. This change detects and optimizes the noop update-settings requests.
61 tasks
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Apr 7, 2021
This test works by capturing the applied cluster state and verifying that it does not change as no-op updates are applied. However the captured cluster state might contain some ongoing relocations which subsequently finish, causing an unexpected cluster state update. This commit fixes that by waiting for any ongoing relocations too. Relates elastic#61348 Closes elastic#70961
DaveCTurner
added a commit
that referenced
this pull request
Apr 7, 2021
This test works by capturing the applied cluster state and verifying that it does not change as no-op updates are applied. However the captured cluster state might contain some ongoing relocations which subsequently finish, causing an unexpected cluster state update. This commit fixes that by waiting for any ongoing relocations too. Relates #61348 Closes #70961
DaveCTurner
added a commit
that referenced
this pull request
Apr 7, 2021
This test works by capturing the applied cluster state and verifying that it does not change as no-op updates are applied. However the captured cluster state might contain some ongoing relocations which subsequently finish, causing an unexpected cluster state update. This commit fixes that by waiting for any ongoing relocations too. Relates #61348 Closes #70961
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This optimization is more relevant in the context of CCR. When a node in the follower leaves, we reallocate the shard-follow tasks on that node to other nodes. The new tasks will overwhelm the follower cluster with many put-mapping, update-settings requests, although most of them are noop. This change detects and optimizes for noop update-settings requests.