Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wait on relocation in UpdateSettingsIT#testNoopUpdate #71401

Merged

Conversation

DaveCTurner
Copy link
Contributor

This test works by capturing the applied cluster state and verifying
that it does not change as no-op updates are applied. However the
captured cluster state might contain some ongoing relocations which
subsequently finish, causing an unexpected cluster state update. This
commit fixes that by waiting for any ongoing relocations too.

Relates #61348
Closes #70961

This test works by capturing the applied cluster state and verifying
that it does not change as no-op updates are applied. However the
captured cluster state might contain some ongoing relocations which
subsequently finish, causing an unexpected cluster state update. This
commit fixes that by waiting for any ongoing relocations too.

Relates elastic#61348
Closes elastic#70961
@DaveCTurner DaveCTurner added >test Issues or PRs that are addressing/adding tests :Distributed Indexing/Distributed A catch all label for anything in the Distributed Area. Please avoid if you can. v8.0.0 v7.13.0 v7.12.1 labels Apr 7, 2021
@elasticmachine elasticmachine added the Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. label Apr 7, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (Team:Distributed)

@DaveCTurner DaveCTurner requested a review from dnhatn April 7, 2021 12:49
Copy link
Member

@dnhatn dnhatn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DaveCTurner DaveCTurner merged commit b24a7e2 into elastic:master Apr 7, 2021
@DaveCTurner DaveCTurner deleted the 2021-04-07-fix-testNoopUpdate branch April 7, 2021 14:04
DaveCTurner added a commit that referenced this pull request Apr 7, 2021
This test works by capturing the applied cluster state and verifying
that it does not change as no-op updates are applied. However the
captured cluster state might contain some ongoing relocations which
subsequently finish, causing an unexpected cluster state update. This
commit fixes that by waiting for any ongoing relocations too.

Relates #61348
Closes #70961
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Distributed Indexing/Distributed A catch all label for anything in the Distributed Area. Please avoid if you can. Team:Distributed (Obsolete) Meta label for distributed team (obsolete). Replaced by Distributed Indexing/Coordination. >test Issues or PRs that are addressing/adding tests v7.12.1 v7.13.0 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CI] UpdateSettingsIT testNoopUpdate failing
4 participants