Check docs limit before indexing on primary #63273
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnhatn
added
>enhancement
:Distributed Indexing/Engine
Collaborator
|
Pinging @elastic/es-distributed (:Distributed/Engine) |
Member
Author
|
run elasticsearch-ci/1 |
DaveCTurner
reviewed
Oct 6, 2020
Contributor
DaveCTurner
left a comment
DaveCTurner
left a comment
There was a problem hiding this comment.
Thanks @dnhatn, this is great. I left a couple of minor questions.
server/src/main/java/org/elasticsearch/index/engine/InternalEngine.java
Outdated
Show resolved
Hide resolved
server/src/internalClusterTest/java/org/elasticsearch/index/engine/MaxDocsLimitIT.java
Outdated
Show resolved
Hide resolved
Member
Author
|
@DaveCTurner Thanks for looking. I've addressed your comments. |
DaveCTurner
reviewed
Oct 7, 2020
Contributor
DaveCTurner
left a comment
DaveCTurner
left a comment
There was a problem hiding this comment.
Thanks @dnhatn; implementation looks good now. I left a couple of suggestions for alternative names and an idea for a more general assertion too.
server/src/internalClusterTest/java/org/elasticsearch/index/engine/MaxDocsLimitIT.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/index/engine/InternalEngine.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/index/engine/InternalEngine.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/index/engine/InternalEngine.java
Outdated
Show resolved
Hide resolved
DaveCTurner
approved these changes
Oct 8, 2020
Contributor
DaveCTurner
left a comment
DaveCTurner
left a comment
There was a problem hiding this comment.
LGTM, thanks @dnhatn
Do we consider this a bug fix? If so, do you think it should go into 7.10?
Member
Author
|
@DaveCTurner Thanks so much for the helpful reviews.
+1. I will backport to 7.10. |
dnhatn
added a commit
to dnhatn/elasticsearch
that referenced
this pull request
Oct 13, 2020
Today indexing to a shard with 2147483519 documents will fail that shard. We should check the number of documents and reject the write requests instead. Closes elastic#51136
dnhatn
added a commit
to dnhatn/elasticsearch
that referenced
this pull request
Oct 13, 2020
Today indexing to a shard with 2147483519 documents will fail that shard. We should check the number of documents and reject the write requests instead. Closes elastic#51136
dnhatn
added a commit
that referenced
this pull request
Oct 13, 2020
Today indexing to a shard with 2147483519 documents will fail that shard. We should check the number of documents and reject the write requests instead. Closes #51136
dnhatn
added a commit
that referenced
this pull request
Oct 13, 2020
Today indexing to a shard with 2147483519 documents will fail that shard. We should check the number of documents and reject the write requests instead. Closes #51136
iverase
added a commit
to iverase/elasticsearch
that referenced
this pull request
Oct 30, 2020
This reverts commit 9015b50.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today indexing to a shard with 2147483519 documents will fail that shard. We should check the number of documents and reject the write requests instead.
Closes #51136