downgrade lucene to 8.6.3 #64332
downgrade lucene to 8.6.3 #64332
Conversation
| final long totalDocs = indexWriter.getPendingNumDocs() + inFlightDocCount.addAndGet(addingDocs); | ||
| //TODO: needs to be adapted to Lucene86? | ||
| //indexWriter.getPendingNumDocs() + inFlightDocCount.addAndGet(addingDocs); | ||
| final long totalDocs = inFlightDocCount.addAndGet(addingDocs); |
There was a problem hiding this comment.
@dnhatn In case we need to perform this action, I am not sure what we need to do here?
There was a problem hiding this comment.
I see two options for this: revert #63273 in 7.10 or manually keep track of the pending documents in Elasticsearch. I prefer the first option as it's error-prone to track the pending documents in Elasticsearch. @DaveCTurner WDYT?
There was a problem hiding this comment.
I revert the commit, could you please check?
There was a problem hiding this comment.
+1 to revert, deferring this bugfix is the right thing to do IMO
|
@elasticmachine run elasticsearch-ci/eql-correctness |
|
@elasticmachine run elasticsearch-ci/eql-correctness |
|
@iverase Should we close this PR? |
|
Lucene 8.7.0 will be released on time so we can close this issue. |
6 participants
Due to a delay on the release of Lucene 8.7.0, this PR downgrades Elasticsearch 7.10 to the previous Lucene version. There are two main challenges: Downgrade RegExp to the previous local implementation and just the InternalEngine as it relays in new methods added in the latest version.