Remove frozen cache setting leniency #71013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We previously allowed but deprecated the ability for the shared cache to be positively sized on nodes without the frozen role. This is because we only allocate shared_cache searchable snapshots to nodes with the frozen role. This commit completes our intention to deprecate/remove this ability.
jasontedor
added
>breaking
:Distributed Coordination/Snapshot/Restore
elasticmachine
added
the
Team:Distributed
|
Pinging @elastic/es-distributed (Team:Distributed) |
…-cache-non-frozen-nodes
dakrone
added a commit
to dakrone/elasticsearch
that referenced
this pull request
Mar 29, 2021
This commit converts the index metadata of searchable snapshot indices using the `shared_cache` storage type to: - Remove all the `index.routing.allocation.(include|exclude|require)._tier` settings - Sets `index.routing.allocation.include._tier_preference` to `data_frozen` automatically when the index metadata is read This is in preperation to enforcing that the `_tier_preference` setting is always set to `data_frozen` for shared cache SBIs. Relates to elastic#70846, elastic#71013, elastic#70786, elastic#70141
|
Can you also update EDIT: and I think we should add a blurb in the migration guide for 8.0 for this as well, since it's breaking? |
|
@dakrone I pushed. |
|
This is stalled on #71084 to easily get the tests to pass here. |
dakrone
added a commit
that referenced
this pull request
Mar 31, 2021
This commit converts the index metadata of searchable snapshot indices using the `shared_cache` storage type to: - Remove all the `index.routing.allocation.(include|exclude|require)._tier` settings - Sets `index.routing.allocation.include._tier_preference` to `data_frozen` automatically when the index metadata is read This is in preperation to enforcing that the `_tier_preference` setting is always set to `data_frozen` for shared cache SBIs. Relates to #70846, #71013, #70786, #70141
dakrone
added a commit
to dakrone/elasticsearch
that referenced
this pull request
Mar 31, 2021
This commit converts the index metadata of searchable snapshot indices using the `shared_cache` storage type to: - Remove all the `index.routing.allocation.(include|exclude|require)._tier` settings - Sets `index.routing.allocation.include._tier_preference` to `data_frozen` automatically when the index metadata is read This is in preperation to enforcing that the `_tier_preference` setting is always set to `data_frozen` for shared cache SBIs. Relates to elastic#70846, elastic#71013, elastic#70786, elastic#70141
dakrone
added a commit
that referenced
this pull request
Mar 31, 2021
…#71129) This commit converts the index metadata of searchable snapshot indices using the `shared_cache` storage type to: - Remove all the `index.routing.allocation.(include|exclude|require)._tier` settings - Sets `index.routing.allocation.include._tier_preference` to `data_frozen` automatically when the index metadata is read This is in preperation to enforcing that the `_tier_preference` setting is always set to `data_frozen` for shared cache SBIs. Relates to #70846, #71013, #70786, #70141
|
@elasticmachine run elasticsearch-ci/bwc |
80 tasks
elasticsearchmachine
pushed a commit
that referenced
this pull request
Sep 15, 2021
…he.size` (#77727) (#77765) We deprecated the `xpack.searchable.snapshot.shared_cache.size` setting on non-frozen nodes in 7.12 with PR #70341. However, we didn't add a related item to the 7.12 deprecation docs. This adds the missing item. Relates to #71013. # Conflicts: # docs/reference/migration/migrate_7_12.asciidoc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We previously allowed but deprecated the ability for the shared cache to be positively sized on nodes without the frozen role. This is because we only allocate shared_cache searchable snapshots to nodes with the frozen role. This commit completes our intention to deprecate/remove this ability.
Relates #70341