Auto convert shared_cache SBIs to only use frozen tier #71014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit converts the index metadata of searchable snapshot indices using the `shared_cache` storage type to: - Remove all the `index.routing.allocation.(include|exclude|require)._tier` settings - Sets `index.routing.allocation.include._tier_preference` to `data_frozen` automatically when the index metadata is read This is in preperation to enforcing that the `_tier_preference` setting is always set to `data_frozen` for shared cache SBIs. Relates to elastic#70846, elastic#71013, elastic#70786, elastic#70141
dakrone
added
:Distributed Coordination/Snapshot/Restore
elasticmachine
added
the
Team:Distributed
|
Pinging @elastic/es-distributed (Team:Distributed) |
henningandersen
approved these changes
Mar 30, 2021
server/src/main/java/org/elasticsearch/cluster/metadata/IndexMetadataVerifier.java
Outdated
Show resolved
Hide resolved
server/src/test/java/org/elasticsearch/cluster/metadata/IndexMetadataVerifierTests.java
Outdated
Show resolved
Hide resolved
dakrone
added a commit
to dakrone/elasticsearch
that referenced
this pull request
Mar 31, 2021
This commit converts the index metadata of searchable snapshot indices using the `shared_cache` storage type to: - Remove all the `index.routing.allocation.(include|exclude|require)._tier` settings - Sets `index.routing.allocation.include._tier_preference` to `data_frozen` automatically when the index metadata is read This is in preperation to enforcing that the `_tier_preference` setting is always set to `data_frozen` for shared cache SBIs. Relates to elastic#70846, elastic#71013, elastic#70786, elastic#70141
dakrone
added a commit
that referenced
this pull request
Mar 31, 2021
…#71129) This commit converts the index metadata of searchable snapshot indices using the `shared_cache` storage type to: - Remove all the `index.routing.allocation.(include|exclude|require)._tier` settings - Sets `index.routing.allocation.include._tier_preference` to `data_frozen` automatically when the index metadata is read This is in preperation to enforcing that the `_tier_preference` setting is always set to `data_frozen` for shared cache SBIs. Relates to #70846, #71013, #70786, #70141
dakrone
added a commit
to dakrone/elasticsearch
that referenced
this pull request
Mar 31, 2021
We already set `data_frozen` for partial searchable snapshots when they are mounted (elastic#70786), and automatically convert values other than the frozen role automatically for these snapshots when the metadata is loaded (elastic#71014). This commit makes the `_tier_preference` setting validate that the setting is *only* `data_frozen` when set on a partial searchable snapshot index.
dakrone
added a commit
that referenced
this pull request
Apr 6, 2021
…71155) We already set `data_frozen` for partial searchable snapshots when they are mounted (#70786), and automatically convert values other than the frozen role automatically for these snapshots when the metadata is loaded (#71014). This commit makes the `_tier_preference` setting validate that the setting is *only* `data_frozen` when set on a partial searchable snapshot index.
dakrone
added a commit
to dakrone/elasticsearch
that referenced
this pull request
Apr 6, 2021
…lastic#71155) We already set `data_frozen` for partial searchable snapshots when they are mounted (elastic#70786), and automatically convert values other than the frozen role automatically for these snapshots when the metadata is loaded (elastic#71014). This commit makes the `_tier_preference` setting validate that the setting is *only* `data_frozen` when set on a partial searchable snapshot index.
dakrone
added a commit
that referenced
this pull request
Apr 13, 2021
…rence (#71155) (#71342) * Enforce data_frozen for partial searchable snapshot _tier_preference (#71155) We already set `data_frozen` for partial searchable snapshots when they are mounted (#70786), and automatically convert values other than the frozen role automatically for these snapshots when the metadata is loaded (#71014). This commit makes the `_tier_preference` setting validate that the setting is *only* `data_frozen` when set on a partial searchable snapshot index. * Handle mixed version clusters with pre-7.13.0 frozen SBIs * Fix checkstyyyyyyyyle * Pass index version in settings for test * Unconditionally return only data_frozen for setting Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit converts the index metadata of searchable snapshot indices using the
shared_cachestorage type to:
index.routing.allocation.(include|exclude|require)._tiersettingsindex.routing.allocation.include._tier_preferencetodata_frozenautomatically when the index metadata is readThis is in preperation to enforcing that the
_tier_preferencesetting is always set todata_frozenfor shared cache SBIs.Relates to #70846, #71013, #70786, #70141