Resurrect _xpack/migration/deprecations routes #75947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joegallo
force-pushed
the
resurrect-xpack-deprecation-routes
branch
from
463808b
to
99bcaf9
Compare
|
See #73930 (comment) re: |
|
Pinging @elastic/clients-team (Team:Clients) |
pgomulka
approved these changes
Aug 5, 2021
| @@ -99,6 +99,9 @@ tasks.named("transformV7RestTests").configure({ task -> | |||
| task.replaceKeyInDo("license.post_start_trial", "xpack-license.post_start_trial") | |||
| task.addAllowedWarningRegex(".*_xpack/license.* is deprecated.*") | |||
|
|
|||
| task.replaceKeyInDo("migration.deprecations", "xpack-migration.deprecations") | |||
| task.addAllowedWarningRegex(".*_xpack/migration.* is deprecated.*") | |||
There was a problem hiding this comment.
maybe we could apply to the test that is using it?
There was a problem hiding this comment.
With #75950, there's only one test that's using the change ("Test get SSL certificates") so it's straightforward to limit ourselves to just the one test. Here, though, there's two ("Test Deprecations" and "Test ml") so I don't think it's worth the additional lines of code to limit ourselves.
I'm going to merge this as is, but if you disagree strongly we can always tweak change it as a new PR against master.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #51816 / #68905.
Adds back the
_xpack/migrationroutes when using rest compatibility for a request.