Resurrect _xpack/ssl/certificates routes #75950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joegallo
force-pushed
the
resurrect-xpack-ssl-routes
branch
from
ffdbb9d to
4a7ae8a
Compare
|
Pinging @elastic/clients-team (Team:Clients) |
|
See #73930 (comment) re: |
sethmlarson
reviewed
Aug 4, 2021
x-pack/plugin/src/yamlRestCompatTest/resources/rest-api-spec/api/xpack-ssl.certificates.json
Show resolved
Hide resolved
pgomulka
approved these changes
Aug 5, 2021
x-pack/plugin/build.gradle
Outdated
| @@ -107,6 +107,9 @@ tasks.named("transformV7RestTests").configure({ task -> | |||
| task.replaceKeyInDo("rollup.start_job", "xpack-rollup.start_job") | |||
| task.replaceKeyInDo("rollup.stop_job", "xpack-rollup.stop_job") | |||
| task.addAllowedWarningRegex(".*_xpack/rollup.* is deprecated.*") | |||
|
|
|||
| task.replaceKeyInDo("ssl.certificates", "xpack-ssl.certificates") | |||
| task.addAllowedWarningRegex(".*_xpack/ssl.* is deprecated.*") | |||
There was a problem hiding this comment.
I guess these are only used in "Test get SSL certificates" ? Maybe it would be worth applying them to that test only?
with addAllowedWarningRegexForTest and replaceKeyInDo with a test name
jakelandis
reviewed
Aug 5, 2021
There was a problem hiding this comment.
Can you add to this test with replaceKeyInDo with a replacement that is only for a single test ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #51816 / #68905.
Adds back the
_xpack/sslroutes when using rest compatibility for a request.