Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid circuit breaker trips in shutdown node actions #86047

Merged
merged 1 commit into from
Apr 21, 2022
Merged

Avoid circuit breaker trips in shutdown node actions #86047

merged 1 commit into from
Apr 21, 2022

Conversation

rjernst
Copy link
Member

@rjernst rjernst commented Apr 20, 2022 •
edited
Loading

When adding or deleting node shutdown metadata, it is important that as
few things go wrong as possible. Since these actions do not do anything
with memory, there is no reason they should trip the circuit breaker,
but they might accidentally if there is pressure on the system. This
commit declares the rest and transport actions as not capable of
tripping the circuit breaker.

closes #84847

@rjernst
Avoid circuit breaker trips in shutdown node actions
34174f9 
When adding or deleting node shutdown metadata, it is important that as
few things go wrong as possible. Since these actions do not do anything
with memory, there is no reason they should trip the circuit breaker,
but they might accidentally if there is pressure on the system. This
commit declares the rest and transport actions as not capable of
tripping the circuit breaker.

closes elastic#84847
@rjernst rjernst added >refactoring :Core/Infra/Node Lifecycle Node startup, bootstrapping, and shutdown v8.3.0 labels Apr 20, 2022
@elasticmachine elasticmachine added the Team:Core/Infra Meta label for core/infra team label Apr 20, 2022
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

@rjernst rjernst requested review from DaveCTurner and pgomulka April 20, 2022 22:21
@rjernst rjernst mentioned this pull request Apr 20, 2022
Closed
5 tasks
DaveCTurner
DaveCTurner approved these changes Apr 21, 2022
View reviewed changes
Copy link
Contributor

@DaveCTurner DaveCTurner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

pgomulka
pgomulka approved these changes Apr 21, 2022
View reviewed changes
Copy link
Contributor

@pgomulka pgomulka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rjernst rjernst merged commit bec3906 into elastic:master Apr 21, 2022
@rjernst rjernst deleted the shutdown/breaker branch April 21, 2022 13:45
@rudolf rudolf mentioned this pull request May 18, 2022
Closed
rjernst added a commit to rjernst/elasticsearch that referenced this pull request May 20, 2022
@rjernst
Avoid circuit breaker trips in shutdown node actions (elastic#86047)
36fc058 
When adding or deleting node shutdown metadata, it is important that as
few things go wrong as possible. Since these actions do not do anything
with memory, there is no reason they should trip the circuit breaker,
but they might accidentally if there is pressure on the system. This
commit declares the rest and transport actions as not capable of
tripping the circuit breaker.

closes elastic#84847
rjernst added a commit to rjernst/elasticsearch that referenced this pull request May 20, 2022
@rjernst
Avoid circuit breaker trips in shutdown node actions (elastic#86047)
14fe7de 
When adding or deleting node shutdown metadata, it is important that as
few things go wrong as possible. Since these actions do not do anything
with memory, there is no reason they should trip the circuit breaker,
but they might accidentally if there is pressure on the system. This
commit declares the rest and transport actions as not capable of
tripping the circuit breaker.

closes elastic#84847
elasticsearchmachine pushed a commit that referenced this pull request May 20, 2022
@rjernst
Avoid circuit breaker trips in shutdown node actions (#86047) (#86994)
0ab2faf 
When adding or deleting node shutdown metadata, it is important that as
few things go wrong as possible. Since these actions do not do anything
with memory, there is no reason they should trip the circuit breaker,
but they might accidentally if there is pressure on the system. This
commit declares the rest and transport actions as not capable of
tripping the circuit breaker.

closes #84847
elasticsearchmachine pushed a commit that referenced this pull request May 23, 2022
@rjernst
Avoid circuit breaker trips in shutdown node actions (#86047) (#86993)
94436c6 
When adding or deleting node shutdown metadata, it is important that as
few things go wrong as possible. Since these actions do not do anything
with memory, there is no reason they should trip the circuit breaker,
but they might accidentally if there is pressure on the system. This
commit declares the rest and transport actions as not capable of
tripping the circuit breaker.

closes #84847
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaveCTurner DaveCTurner DaveCTurner approved these changes

@pgomulka pgomulka pgomulka approved these changes

Assignees
No one assigned
Labels
:Core/Infra/Node Lifecycle Node startup, bootstrapping, and shutdown >refactoring Team:Core/Infra Meta label for core/infra team v7.17.5 v8.2.1 v8.3.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Node shutdown cluster state task improvements
4 participants
@rjernst @elasticmachine @DaveCTurner @pgomulka