Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid circuit breaker trips in shutdown node actions #86047

Merged
merged 1 commit into from
Apr 21, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,11 @@ public List<Route> routes() {
return List.of(new Route(RestRequest.Method.DELETE, "/_nodes/{nodeId}/shutdown"));
}

@Override
public boolean canTripCircuitBreaker() {
return false;
}

@Override
protected RestChannelConsumer prepareRequest(RestRequest request, NodeClient client) {
String nodeId = request.param("nodeId");
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,11 @@ public List<Route> routes() {
return List.of(new Route(RestRequest.Method.PUT, "/_nodes/{nodeId}/shutdown"));
}

@Override
public boolean canTripCircuitBreaker() {
return false;
}

@Override
protected RestChannelConsumer prepareRequest(RestRequest request, NodeClient client) throws IOException {
String nodeId = request.param("nodeId");
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,7 @@ public TransportDeleteShutdownNodeAction(
) {
super(
DeleteShutdownNodeAction.NAME,
false,
transportService,
clusterService,
threadPool,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -155,6 +155,7 @@ public TransportPutShutdownNodeAction(
) {
super(
PutShutdownNodeAction.NAME,
false,
transportService,
clusterService,
threadPool,
Expand Down