Fix double sending of response in TransportOpenIdConnectPrepareAuthenticationAction #89930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ticationAction This fixes an obvious bug where the listener was resolved twice if any of the first two failure conditions in the changed method were met. Prior to elastic#89873 this would lead to a memory leak.
original-brownbear
added
>bug
:Security/Authentication
|
Pinging @elastic/es-security (Team:Security) |
|
Hi @original-brownbear, I've created a changelog YAML for you. |
|
Thanks Slobodan! |
original-brownbear
added a commit
to original-brownbear/elasticsearch
that referenced
this pull request
Sep 9, 2022
…ticationAction (elastic#89930) This fixes an obvious bug where the listener was resolved twice if any of the first two failure conditions in the changed method were met. Prior to elastic#89873 this would lead to a memory leak.
original-brownbear
added a commit
to original-brownbear/elasticsearch
that referenced
this pull request
Sep 9, 2022
…ticationAction (elastic#89930) This fixes an obvious bug where the listener was resolved twice if any of the first two failure conditions in the changed method were met. Prior to elastic#89873 this would lead to a memory leak.
elasticsearchmachine
pushed a commit
that referenced
this pull request
Sep 9, 2022
…eAuthenticationAction (#89930) (#89953) * Fix double sending of response in TransportOpenIdConnectPrepareAuthenticationAction (#89930) This fixes an obvious bug where the listener was resolved twice if any of the first two failure conditions in the changed method were met. Prior to #89873 this would lead to a memory leak. * fix compile
weizijun
added a commit
to weizijun/elasticsearch
that referenced
this pull request
Sep 9, 2022
* main: (176 commits) Fix RandomSamplerAggregatorTests testAggregationSamplingNestedAggsScaled test failure (elastic#89958) [Downsampling] Replace document map with SMILE encoded doc (elastic#89495) Remove full cluster state from error logging in MasterService (elastic#89960) [ML] Truncate categorization fields (elastic#89827) [TSDB] Removed `summary` and `histogram` metric types (elastic#89937) Update testNodeSelectorRouting so that it does not depend on iteration order (elastic#89879) Make sure listener is resolved when file queue is cleared (elastic#89929) [Stable plugin api] Extensible annotation (elastic#89903) Fix double sending of response in TransportOpenIdConnectPrepareAuthenticationAction (elastic#89930) Make sure ivy repo directory exists before downloading artifacts Use 'file://' scheme for local repository URL Use DRA artifacts for release build CI jobs Log unsuccessful attempts to get credentials from web identity tokens (elastic#88241) Script: Write Field API path manipulation (elastic#89889) Fetch health info action (elastic#89820) Fix memory leak in TransportDeleteExpiredDataAction (elastic#89935) [ML] Performance improvements for categorization jobs (elastic#89824) [DOCS] Revert changes for ES_JAVA_OPTS (elastic#89931) Fix deadlock bug exposed by a test (elastic#89934) [Downsampling] Remove `FieldValueFetcher` validator (elastic#89497) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an obvious bug where the listener was resolved twice if any of the first two failure conditions in the changed method were met. Prior to #89873 this would lead to a memory leak.
This is actually observable in the real world looking at cloud failure logs.