Fix RandomSamplerAggregatorTests testAggregationSamplingNestedAggsScaled test failure #89958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…led test failure This test indexes 150 documents. In case the test index has a high number of shards, it can happen that no documents get sampled. I think this is expected behaviour in this case. This commit adds a special case for this situation, by expected other counts to be 0 if sampled doc count is 0 as well. Closes elastic#89818
martijnvg
added
>test
|
Pinging @elastic/es-analytics-geo (Team:Analytics) |
elasticsearchmachine
added
v8.5.0
Team:Analytics
not-napoleon
approved these changes
Sep 9, 2022
There was a problem hiding this comment.
LGTM. I do wonder if we should return an error, or at least a warning, if the sampler ever gets zero docs. @benwtrent is on parental leave right now, but might be worth discussing with him when he gets back.
Salvatore and I were also doubting about what desired behaviour should be in this case. I think it makes to discuss this later. Should I open a team discuss issue for this? |
|
@elasticmachine run elasticsearch-ci/rest-compatibility |
|
Odd rest compat build did succeed according to logs... |
weizijun
added a commit
to weizijun/elasticsearch
that referenced
this pull request
Sep 9, 2022
* main: (176 commits) Fix RandomSamplerAggregatorTests testAggregationSamplingNestedAggsScaled test failure (elastic#89958) [Downsampling] Replace document map with SMILE encoded doc (elastic#89495) Remove full cluster state from error logging in MasterService (elastic#89960) [ML] Truncate categorization fields (elastic#89827) [TSDB] Removed `summary` and `histogram` metric types (elastic#89937) Update testNodeSelectorRouting so that it does not depend on iteration order (elastic#89879) Make sure listener is resolved when file queue is cleared (elastic#89929) [Stable plugin api] Extensible annotation (elastic#89903) Fix double sending of response in TransportOpenIdConnectPrepareAuthenticationAction (elastic#89930) Make sure ivy repo directory exists before downloading artifacts Use 'file://' scheme for local repository URL Use DRA artifacts for release build CI jobs Log unsuccessful attempts to get credentials from web identity tokens (elastic#88241) Script: Write Field API path manipulation (elastic#89889) Fetch health info action (elastic#89820) Fix memory leak in TransportDeleteExpiredDataAction (elastic#89935) [ML] Performance improvements for categorization jobs (elastic#89824) [DOCS] Revert changes for ES_JAVA_OPTS (elastic#89931) Fix deadlock bug exposed by a test (elastic#89934) [Downsampling] Remove `FieldValueFetcher` validator (elastic#89497) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test indexes 150 documents. In case the test index has a high number of segments, it can happen that no documents get sampled. I think this is expected behaviour in this case.
A more detailed explanation of how this failure can happen: #89818 (comment)
This commit adds a special case for this situation, by expecting other counts to be 0 if sampled doc count is 0 as well.
Closes #89818