-
Notifications
You must be signed in to change notification settings - Fork 841
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Table cells should have a way to turn off text mode #2
Comments
FWIW we can discuss the contribution process in the call tomorrow, but as far as I'm concerned the following would be a fair process:
|
cjcenizal
referenced
this issue
in cjcenizal/eui
Jan 26, 2018
- since the default props docs don't support rich props hierarchy, we construct the docgen info ourselves. - changes the styling of the props docs - introduced a special `_euiObjectType` field in docgenInfo "mark" the documented component as a "type" rather than a react component - added internal links between the different types
cjcenizal
referenced
this issue
in cjcenizal/eui
Jan 28, 2018
- since the default props docs don't support rich props hierarchy, we construct the docgen info ourselves. - changes the styling of the props docs - introduced a special `_euiObjectType` field in docgenInfo "mark" the documented component as a "type" rather than a react component - added internal links between the different types
nreese
added a commit
that referenced
this issue
Apr 18, 2018
* use react-virtualized to virtualize combo box options list * use smaller width and height * include group label in matching options list * add better text for example description * dynamically set width and height * Massage group title padding. Truncate text instead of wrapping it. Add title attribute to options for usability. (#1) * remove console.log and fix spelling * fix problems with settig focus on active option * more keyboard accessiblity work * Combo box focus state and text overflow (#2) * Call setState instead of setting activeOptionIndex directly. * Clear activeOptionIndex when you click the input. * Prevent a lot of input from overflowing the container. * Allow disabled options to be focused but not selected. * add throttle to incrementActiveOptionIndex to avoid keypresses getting UI out of sync * rowHeight prop * remove unneeded const * fix spacing in example text, fix lodash import * skip disabled options when using keyboard * Revert "skip disabled options when using keyboard" This reverts commit 47fa3ef.
elizabetdev
referenced
this issue
in elizabetdev/eui
Dec 11, 2019
…ticPages Heldrida feature/history api and static pages
chandlerprall
pushed a commit
that referenced
this issue
Mar 16, 2020
* fixed errors * updated changelog * Update CHANGELOG.md * added preview in docs-section * Update CHANGELOG.md * added example file * Fixing anchor and disabled styles, updating example (#2) Thanks @cchaos * added tests * Update CHANGELOG.md Co-Authored-By: Caroline Horn <549577+cchaos@users.noreply.github.com> Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com>
shrey
added a commit
to shrey/eui
that referenced
this issue
Jun 12, 2020
10 tasks
4 tasks
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In this snippet:
eui/src/components/table/table_row_cell.js
Line 32 in 52636ec
The issue is that when we want to render full-width cells such as Node distribution in the following table:
We need to do something like
.ourTable .kuiTableCellContent__text { width: 100% }
. Is this reasonable, or should we have a prop to turn off the text mode, whereby we don't add the extra span highlighted here:I'd rather not have consumers need to dig into the internal classes as much as possible (in the context of React components at least), since that's the value in React for the most part, abstracting the classes away
In conclusion, would it be possible to do something like:
The text was updated successfully, but these errors were encountered: