Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EuiBasicTable blocks any action while isLoading is true #5014

Closed
cauemarcondes opened this issue Aug 10, 2021 · 13 comments · Fixed by #6543
Closed

EuiBasicTable blocks any action while isLoading is true #5014

cauemarcondes opened this issue Aug 10, 2021 · 13 comments · Fixed by #6543

Comments

@cauemarcondes
Copy link

on APM we’re lazy loading part of the data that we show on a EuiBasicTable . The problem is that I cannot click on anything while isLoading = true.

lazy.loading.mov

Expected behavior:
The table would allow the user to click on any link in the table even when the loading spinner is running.

@cauemarcondes
Copy link
Author

cc: @formgeist / @sqren

@sorenlouv
Copy link
Member

Related: elastic/kibana#103645

@thompsongl
Copy link
Contributor

thompsongl commented Aug 11, 2021

Per comments elsewhere, preventing interaction is the intended behavior:

private addLoadingListeners = (tbody: HTMLTableSectionElement) => {

Open to discussions about changing that decision

@github-actions
Copy link

github-actions bot commented Feb 7, 2022

👋 Hey there. This issue hasn't had any activity for 180 days. We'll automatically close it if that trend continues for another week. If you feel this issue is still valid and needs attention please let us know with a comment.

@sorenlouv
Copy link
Member

@cauemarcondes Is this still an issue? If so, should we engage with EUI team to discuss it?

@cauemarcondes
Copy link
Author

@cauemarcondes Is this still an issue? If so, should we engage with EUI team to discuss it?

Apparently, it's no longer an issue @sqren .

Screen.Recording.2022-02-10.at.9.26.51.AM.mov

@sorenlouv
Copy link
Member

Apparently, it's no longer an issue @sqren

That video doesn't show you clicking on on a link while the table is loading. So I'm not convinced this is fixed.

@cauemarcondes
Copy link
Author

The problem happened while you tried to click on a service link while the sparklines are still loading, in the video, you can see that there's no sparkling yet for the services listed, so it's still being fetched, but I'm now able to click and navigate to a service details.

@sorenlouv
Copy link
Member

@cauemarcondes I can still reproduce the problem. As long as the table data is loading the content becomes unresponsive to clicks:

unresponsive-table

@sorenlouv
Copy link
Member

Ah, I think I get what you are saying now: it's blocking while loading the primary content (the links) but will not block if it's just the sparklines that are missing?

I agree, that's probably acceptable.

@formgeist
Copy link
Contributor

Agree, it is acceptable as long as the user can navigate without having to wait on the sparklines (or other metrics related data) to load 👍

@cauemarcondes
Copy link
Author

Ah, I think I get what you are saying now: it's blocking while loading the primary content (the links) but will not block if it's just the sparklines that are missing?

yes, that's it.

@cee-chen
Copy link
Contributor

Re-opening this - we've investigated and have determined this behavior is an accessibility issue at worst and unnecessary UX at best. We will be removing this logic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants