Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Color Theme Picker Lacking Context #617

Closed
aphelionz opened this issue Apr 2, 2018 · 0 comments · Fixed by #821
Closed

Color Theme Picker Lacking Context #617

aphelionz opened this issue Apr 2, 2018 · 0 comments · Fixed by #821
Labels
accessibility - WCAG A Level A WCAG Accessibility Criteria accessibility

Comments

@aphelionz
Copy link
Contributor

Steps to reproduce (assumes ChromeVox or similar)

image

  1. [Tab] or [Shift+Tab] to the color theme picker at the top left of the page
  2. Listen to the screen reader

Actual Result

Elastic UI tilde light, button collapsed

Expected Result

"Choose a color theme. Current theme: light, button collapsed"

Here you want to indicate two things:

  1. That there is a list here. "button collapsed" implies this, but it should be explicit
  2. That the current selected item is "light"

Suggested Fix
Provide more narrated context either by utilizing the simple title attribute.
Category: #615: Elastic UI Chrome Accessibility
Relevant WCAG Criteria: 2.4.4 Link Purpose (In Context)
@aphelionz aphelionz mentioned this issue Apr 2, 2018
Closed
9 tasks
@aphelionz aphelionz added the accessibility - WCAG A Level A WCAG Accessibility Criteria label May 6, 2018
snide added a commit to snide/eui that referenced this issue May 11, 2018
@snide
fixes elastic#617 applies aria label to theme selector
1c89762
@snide snide mentioned this issue May 11, 2018
Merged
snide added a commit that referenced this issue May 14, 2018
@snide
Fixes for accessibility tickets (#821)
a153c7a 
* pagination labeling fixes #735
* fixes #621 adds menubar roles to side nav
* fixes #734, adds more descriptive aria labeling for pagination
* fixes #729, apply aria-live to popovers
* fixes #723, provides screen reader notice for bottom bar appearance
* fix ownFocus needing to be true for non-context menu sitations. apply aria labels depending upon ownFocus state
* fixes #616 adds home page label
* fixes #687, documentation button labeling
* fixes #617 applies aria label to theme selector
* fixes #746 applies proper label to select all checkboxes in table
* clone element and id no longer needed for popover
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
accessibility - WCAG A Level A WCAG Accessibility Criteria accessibility
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes for accessibility tickets snide/eui
2 participants
@aphelionz @snide