Fixes for accessibility tickets #821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chandlerprall
suggested changes
May 11, 2018
| @@ -93,11 +93,15 @@ export class GuidePageChrome extends Component { | |||
| } | |||
|
|
|||
| renderSubSections = (subSections = []) => { | |||
| if (subSections.length <= 1) { | |||
| console.log(subSections); | |||
| @@ -32,6 +33,10 @@ export class EuiBottomBar extends Component { | |||
| } | |||
| } | |||
|
|
|||
| handleScreenReaderFocus() { | |||
There was a problem hiding this comment.
Where/how is this used?
… aria labels depending upon ownFocus state
|
@chandlerprall sorry, still working on this one. should have attached WIP status to it. |
|
OK. I'm done on this one for the day. I think the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #733
Fixes #734
Fixes #735
Fixes #621
Fixes #736
Fixes #728
Fixes #729
Fixes #723
Fixes #616
Fixes #687
Fixes #617
Fixes #746
Grab bag of accessibility fixes. The following changes were made.
EuiPaginationmore friendly for screen readers.EuiSideNavuse menubar labeling. Of all the options (nav / tree...etc) it was the most agreeable with our current formatting.EuiPopoverwhereownFocswas required if it didn't wrap a context menu. MadeEuiPopoveruse anaria-livelabel to announce its contents if it isn't set (with the assumption that if it is, the SR will read what it focused).EuiBottomBarnow has some hidden SR text to announce itself.EuiBasicTablenow labels its checkboxes properly.