Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EuiCard should use role=heading where appropriate #979

Closed
timroes opened this issue Jul 9, 2018 · 0 comments
Closed

EuiCard should use role=heading where appropriate #979

timroes opened this issue Jul 9, 2018 · 0 comments
Assignees

Comments

@timroes
Copy link
Contributor

timroes commented Jul 9, 2018

Currently EuiCard never uses a proper header. In case the whole card is a button that is fine (and everything else would be breaking with HTML spec).

In case we actually render the button inside the card, I think it would make sense to make the (visual) header an actual HTML header, most likely by using role="heading" on it and allow the user to customize which level it sits (which should be set via aria-level in that case).

cc @bhavyarm @nreese

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants