Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EuiCard updates #1032

Merged
merged 6 commits into from
Jul 20, 2018
Merged

EuiCard updates #1032

merged 6 commits into from
Jul 20, 2018

Conversation

cchaos
Copy link
Contributor

@cchaos cchaos commented Jul 19, 2018 •
edited
Loading

Fixes #979 Allow titleElement to be passed to EuiCard

You can pass any heading level h2-h6 to wrap the title in. It will default to span but also force to span if inside a button.

cc @timroes

Fixes #977 Beta label now shows out of panel bounds in IE

IE screenshot:
screen shot 2018-07-19 at 10 43 34 am

cc @bhavyarm

chandlerprall
chandlerprall approved these changes Jul 19, 2018
View reviewed changes
Copy link
Contributor

@chandlerprall chandlerprall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code change LGTM

@cchaos
Copy link
Contributor Author

cchaos commented Jul 20, 2018

@snide Can I get a review?

snide
snide approved these changes Jul 20, 2018
View reviewed changes
Copy link
Contributor

@snide snide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked code and loaded in browser. All good.

@cchaos cchaos merged commit 9ff827b into elastic:master Jul 20, 2018
@cchaos cchaos deleted the card-updates branch July 20, 2018 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snide snide snide approved these changes

@chandlerprall chandlerprall chandlerprall approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cchaos @chandlerprall @snide