Mark properties on EUIFlyout as optional in typings #1003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uboness
reviewed
Jul 12, 2018
| @@ -1,15 +1,15 @@ | |||
| declare module '@elastic/eui' { | |||
| export interface EuiFlyoutProps { | |||
| onClose: () => void; | |||
There was a problem hiding this comment.
should we add children?: ReactNode; to props of components that can have children. The official defs that come with react do that (eg. DOMAttributes). For most of the existing EUI defs we inherit that from DOMAttributes and HTMLAttributes). While I think it's not a must or critical (that is, things will work without it), I believe that it also serves an accurate documentation for the use and capabilities of the components.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry for the quick merge @timroes, fixing my mistake here.