Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more EuiContextMenuItemProps typings #1006

Merged

Conversation

stacey-gammon
Copy link
Contributor

@stacey-gammon stacey-gammon commented Jul 12, 2018

fixes #985 and #950

Copy link
Contributor

@chandlerprall chandlerprall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mind filling out the rest of the props?

@stacey-gammon stacey-gammon changed the title Add disabled and onClick options to EuiContextMenuItemProps Add more EuiContextMenuItemProps typings Jul 12, 2018
@stacey-gammon
Copy link
Contributor Author

hows this look? Also added in children per @uboness's comment on #1003 (comment)

@stacey-gammon stacey-gammon force-pushed the 2018-07-12-context-menu-item-props branch from 5bf5d45 to 4fc31c1 Compare July 12, 2018 21:07
Copy link
Contributor

@chandlerprall chandlerprall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DISCUSS] Typescript: EuiContextMenuItem icon should be able to be a non-react element
2 participants