Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EuiOverlayMask TS fix #1900

Merged
merged 6 commits into from
Apr 30, 2019
Merged

Conversation

thompsongl
Copy link
Contributor

@thompsongl thompsongl commented Apr 30, 2019

Summary

Fixes children interface mismatches (below), which relates to the now-known #1890 about children element type restrictions/modifications. The type changes are not as well-defined as we'd like, but there is not good workaround yet.

Type 'Element' is not assignable to type 'string | ({} & string) | (ReactElement<any, string | ((props: any) => ReactElement<any, string | ... | (new (props: any) => Component<any, any, any>)> | null) | (new (props: any) => Component<any, any, any>)> & string) | (ReactNodeArray & string) | (ReactPortal & string) | undefined'.
  Type 'Element' is not assignable to type 'ReactPortal & string'.
    Type 'Element' is not assignable to type 'ReactPortal'.

Checklist

- [ ] This was checked in mobile
- [ ] This was checked in IE11
- [ ] This was checked in dark mode
- [ ] Any props added have proper autodocs
- [ ] Documentation examples were added

  • A changelog entry exists and is marked appropriately

- [ ] This was checked for breaking changes and labeled appropriately
- [ ] Jest tests were updated or added to match the most common scenarios
- [ ] This was checked against keyboard-only and screenreader scenarios
- [ ] This required updates to Framer X components

Copy link
Contributor

@chandlerprall chandlerprall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good; built eui.d.ts locally to test EuiOverlayMask usage before & after fix.

@thompsongl thompsongl merged commit b4febb3 into elastic:master Apr 30, 2019
@cchaos
Copy link
Contributor

cchaos commented May 9, 2019

@thompsongl This is now causing an error from EuiFlyout which doesn't pass any children to the overlay mask.

Screen Shot 2019-05-09 at 10 34 24 AM

Maybe just make children optional?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants