Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EuiOverlayMask TS fix #1900

Merged
merged 6 commits into from
Apr 30, 2019
Merged

EuiOverlayMask TS fix #1900

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
045a194
simplify props def
thompsongl Apr 30, 2019
3926655
omit onClick
thompsongl Apr 30, 2019
8858465
#1900 CL entry
thompsongl Apr 30, 2019
f30269c
partial reversion; explicit children type
thompsongl Apr 30, 2019
8684267
require children
thompsongl Apr 30, 2019
0275ee2
Merge branch 'master' into overlay-mask-ts-fix
thompsongl Apr 30, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
## [`master`](https://github.com/elastic/eui/tree/master)

No public interface changes since `10.2.1`.
**Bug fixes**

- Fixed `EuiOverlayMask` `children` element mismatch TS error ([#1900](https://github.com/elastic/eui/pull/1900))

## [`10.2.1`](https://github.com/elastic/eui/tree/v10.2.1)

Expand Down
3 changes: 2 additions & 1 deletion src/components/overlay_mask/overlay_mask.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,14 @@
* into portals.
*/

import { Component, HTMLAttributes } from 'react';
import { Component, HTMLAttributes, ReactNode } from 'react';
import { createPortal } from 'react-dom';
import classNames from 'classnames';
import { CommonProps, keysOf, Omit } from '../common';

export interface EuiOverlayMaskProps {
onClick?: () => void;
children: ReactNode;
}

export type Props = CommonProps &
Expand Down