-
Notifications
You must be signed in to change notification settings - Fork 843
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Close EuiComboBox options when the page scrolls #2106
Close EuiComboBox options when the page scrolls #2106
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested in Chrome 👍
Tested in Fireforx 🆗 There's a bit of a lag before it will disappear but it's better than the alternative.
Happens occasionally in some browsers besides Firefox, unfortunately that's from the browsers not emitting scroll events quickly, which is done for performance reasons :-/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested in Firefox, Chrome, Safari, IE11, and Edge.
Saw the lag, also, but otherwise 👍
Looks like a snapshot needs updating. CL, too.
Summary
Fixes #2099 by auto-closing the combo box's options popover on scroll events.
I modified the first combo box example to the following for this within a scrollable container
Checklist
- [ ] This was checked in dark mode- [ ] Any props added have proper autodocs- [ ] Documentation examples were added- [ ] Jest tests were updated or added to match the most common scenarios- [ ] This was checked against keyboard-only and screenreader scenarios- [ ] This required updates to Framer X components