Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EuiFilterSelect add missing TS def #2291

Merged
merged 5 commits into from
Sep 9, 2019
Merged

EuiFilterSelect add missing TS def #2291

merged 5 commits into from
Sep 9, 2019

Conversation

justinkambic
Copy link
Contributor

Summary

Recently I was using EuiFilterSelect and had a hard time figuring out how to use it because onClick is not documented, even though it might be obvious.

In this patch I've added a propTypes definition, as well as a field on the exported TS type.

Checklist

  • Checked in dark mode
  • Checked in mobile
  • Checked in IE11 and Firefox
  • Props have proper autodocs
  • Added documentation examples
  • Added or updated jest tests
  • Checked for breaking changes and labeled appropriately
  • Checked for accessibility including keyboard-only and screenreader modes
  • A changelog entry exists and is marked appropriately

@justinkambic justinkambic added documentation Issues or PRs that only affect documentation - will not need changelog entries typescript labels Sep 5, 2019
@justinkambic justinkambic self-assigned this Sep 5, 2019
@thompsongl
Copy link
Contributor

Nice! Are you planning on adding some more commits before taking this out of Draft status?

@justinkambic
Copy link
Contributor Author

Are you planning on adding some more commits before taking this out of Draft status?

Negative!

@justinkambic justinkambic marked this pull request as ready for review September 5, 2019 21:50
thompsongl
thompsongl approved these changes Sep 6, 2019
View reviewed changes
Copy link
Contributor

@thompsongl thompsongl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@justinkambic justinkambic merged commit e0b1890 into elastic:master Sep 9, 2019
@justinkambic justinkambic deleted the euiFilterSelect-typing branch September 9, 2019 13:52
@thompsongl thompsongl mentioned this pull request Sep 9, 2019
Merged
thompsongl pushed a commit to thompsongl/eui that referenced this pull request Sep 10, 2019
@justinkambic @thompsongl
EuiFilterSelect add missing TS def (elastic#2291)
fa163b7 
* Add missing TS def for EuiFilterSelect.

* Update CHANGELOG.md

* Add "Bug fixes" heading to CHANGELOG entry.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chandlerprall chandlerprall chandlerprall approved these changes

@thompsongl thompsongl thompsongl approved these changes

Assignees

@justinkambic justinkambic

Labels
documentation Issues or PRs that only affect documentation - will not need changelog entries typescript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@justinkambic @thompsongl @chandlerprall