-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade EUI to 13.8.1 #45052
Upgrade EUI to 13.8.1 #45052
Conversation
💔 Build Failed |
package.json, snapshot, code, and yarn.lock changes LGTM pending changes for tests |
💚 Build Succeeded |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM from the infra
plugin perspective
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Platform changes good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ML changes LGTM.
Re-ping @elastic/apm-ui and @elastic/kibana-security Other owned coder pings were for snapshot tests only |
</EuiContextMenuItem> | ||
) : null | ||
); | ||
.map(({ icon, key, child }) => ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change looks good but not really related to the EUI update, is it?
Do leave it in though 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
EuiContextMenuPanel
was converted to TS and its items
prop no longer accepts null
entries (it never really did, but it wasn't typed). Removing the unneeded conditional returns a null
-less array, which passes the type check.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes in Security and Spaces plugins LGTM.
* eui to 13.8.0 * euibutton ts updates * euicontextmenupanel ts updates * misc ts updates * src snapshot updates * x-pack snapshot updates * 13.8.1
…-to-np-ready * 'master' of github.com:elastic/kibana: Upgrade EUI to 13.8.1 (elastic#45052) [ML] Add multi metric job wizard test (elastic#45279) [SIEM] Inject/apply KQL changed in refresh button (elastic#45065) [Graph] Type persistence (elastic#44985) Functional tests: convert more test/services to TS (elastic#45176)
…ditor * 'master' of github.com:elastic/kibana: (76 commits) Upgrade EUI to 13.8.1 (elastic#45052) [ML] Add multi metric job wizard test (elastic#45279) [SIEM] Inject/apply KQL changed in refresh button (elastic#45065) [Graph] Type persistence (elastic#44985) Functional tests: convert more test/services to TS (elastic#45176) [ML] Fixes display of matching modules in index data visualizer (elastic#45261) [Console] Update indentation behaviour (elastic#45249) Convert value provided to PhraseValueInput to string to catch Exception (elastic#45259) [Region Map] Fix loading default vector map and base layer setting (elastic#43858) [ML] Fixing empty time range when cloning jobs (elastic#45286) [ML] Fixing wizard validation delay (elastic#45265) [Logs UI] Interpret finished analysis jobs as healthy (elastic#45268) [Console] SQL template with triple quote in completion (elastic#45248) [ML] Data Frames: Cards as links (elastic#45254) fix(code/frontend): should show updating instead of cloning when updating (elastic#45238) fix(code/frontend): fix document search result from (elastic#45236) disable another flaky suite (elastic#45323) (elastic#45330) disable flaky suite (elastic#45105) skip flaky suite (elastic#43069) skip flaky suite (elastic#45089) ...
eui@13.6.1 ⏩ eui@13.8.1
EuiButton
and Co.,EuiTable
and Co.)elastic-charts
Snapshot churn is largely due to TS conversions, which express more props (explicit default values instead of
defaultProps
)13.8.1
Bug fixes
EuiFilterSelect
(#2291)EuiSideNavItem
(#2297)EuiContextMenu
to account for index of0
(#2304)13.8.0
EuiTab
and converted to TypeScript (#2275)EuiInputPopover
component (formally) (#2269)Bug fixes
EuiSuperDatePicker
(#2236)onClick
type forEuiButtonEmpty
(#2282)dist
charts theme module (#2294)13.7.0
EuiFlexGroup
to accept aref
(#2223)Bug fixes
EuiSuperDatePicker
to updateasyncInterval.isStopped
on aisPaused
prop change. (#2250)EuiStat
invalid DOM nesting due to a<p>
tag nested within another<p>
tag (#2229)EuiNavDrawer
(#2261)