Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade EUI to 13.8.1 #45052

Merged
merged 9 commits into from
Sep 11, 2019
Merged

Upgrade EUI to 13.8.1 #45052

merged 9 commits into from
Sep 11, 2019

Conversation

thompsongl
Copy link
Contributor

@thompsongl thompsongl commented Sep 6, 2019

eui@13.6.1eui@13.8.1

  • Many components converted to TypeScript (e.g., EuiButton and Co., EuiTable and Co.)
  • EUI theme and docs for elastic-charts

Snapshot churn is largely due to TS conversions, which express more props (explicit default values instead ofdefaultProps)


13.8.1

Bug fixes

  • Updated TS def for EuiFilterSelect (#2291)
  • Fixed alignment of icons and label in EuiSideNavItem (#2297)
  • Fixed logic in EuiContextMenu to account for index of 0 (#2304)

13.8.0

  • Added href prop to EuiTab and converted to TypeScript (#2275)
  • Created EuiInputPopover component (formally) (#2269)
  • Added docs for using Elastic Charts with EUI (#2209)

Bug fixes

  • Removed extra right side margin in EuiSuperDatePicker (#2236)
  • Fixed incorrect onClick type for EuiButtonEmpty (#2282)
  • Fixed compilation script to remove all TypeScript definition exports from built JS assets (#2279)
  • Fixed output extension for dist charts theme module (#2294)

13.7.0

  • Allow EuiFlexGroup to accept a ref (#2223)

Bug fixes

  • Fixed EuiSuperDatePicker to update asyncInterval.isStopped on a isPaused prop change. (#2250)
  • Converted table, popover, buttons, pagination, outside click detector, focus trap, context menu, and panel to TypeScript (#2212)
  • Fixed EuiStat invalid DOM nesting due to a <p> tag nested within another <p> tag (#2229)
  • Fixed title text of dock/undock icon in EuiNavDrawer (#2261)

@thompsongl thompsongl added chore v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.5.0 labels Sep 6, 2019
@elasticmachine
Copy link
Contributor

💔 Build Failed

@chandlerprall
Copy link
Contributor

package.json, snapshot, code, and yarn.lock changes LGTM pending changes for tests

@thompsongl thompsongl changed the title Upgrade EUI to 13.8.0 Upgrade EUI to 13.8.1 Sep 9, 2019
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@thompsongl thompsongl marked this pull request as ready for review September 9, 2019 18:24
@thompsongl thompsongl requested review from a team as code owners September 9, 2019 18:24
@thompsongl thompsongl requested a review from a team September 9, 2019 18:24
@thompsongl thompsongl requested a review from a team as a code owner September 9, 2019 18:24
Copy link
Contributor

@chandlerprall chandlerprall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM!

Copy link
Member

@weltenwort weltenwort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from the infra plugin perspective

Copy link
Contributor

@joshdover joshdover left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Platform changes good

Copy link
Contributor

@walterra walterra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ML changes LGTM.

@thompsongl
Copy link
Contributor Author

Re-ping @elastic/apm-ui and @elastic/kibana-security

Other owned coder pings were for snapshot tests only

</EuiContextMenuItem>
) : null
);
.map(({ icon, key, child }) => (
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change looks good but not really related to the EUI update, is it?
Do leave it in though 👍

Copy link
Contributor Author

@thompsongl thompsongl Sep 10, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EuiContextMenuPanel was converted to TS and its items prop no longer accepts null entries (it never really did, but it wasn't typed). Removing the unneeded conditional returns a null-less array, which passes the type check.

Copy link
Member

@sorenlouv sorenlouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@azasypkin azasypkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes in Security and Spaces plugins LGTM.

@thompsongl thompsongl merged commit bec1fa6 into elastic:master Sep 11, 2019
thompsongl added a commit to thompsongl/kibana that referenced this pull request Sep 11, 2019
* eui to 13.8.0

* euibutton ts updates

* euicontextmenupanel ts updates

* misc ts updates

* src snapshot updates

* x-pack snapshot updates

* 13.8.1
jloleysens added a commit to jloleysens/kibana that referenced this pull request Sep 11, 2019
…-to-np-ready

* 'master' of github.com:elastic/kibana:
  Upgrade EUI to 13.8.1 (elastic#45052)
  [ML] Add multi metric job wizard test (elastic#45279)
  [SIEM] Inject/apply KQL changed in refresh button (elastic#45065)
  [Graph] Type persistence (elastic#44985)
  Functional tests: convert more test/services to TS (elastic#45176)
jloleysens added a commit to jloleysens/kibana that referenced this pull request Sep 11, 2019
…ditor

* 'master' of github.com:elastic/kibana: (76 commits)
  Upgrade EUI to 13.8.1 (elastic#45052)
  [ML] Add multi metric job wizard test (elastic#45279)
  [SIEM] Inject/apply KQL changed in refresh button (elastic#45065)
  [Graph] Type persistence (elastic#44985)
  Functional tests: convert more test/services to TS (elastic#45176)
  [ML] Fixes display of matching modules in index data visualizer (elastic#45261)
  [Console] Update indentation behaviour (elastic#45249)
  Convert value provided to PhraseValueInput to string to catch Exception (elastic#45259)
  [Region Map] Fix loading default vector map and base layer setting (elastic#43858)
  [ML] Fixing empty time range when cloning jobs (elastic#45286)
  [ML] Fixing wizard validation delay (elastic#45265)
  [Logs UI] Interpret finished analysis jobs as healthy (elastic#45268)
  [Console] SQL template with triple quote in completion (elastic#45248)
  [ML] Data Frames: Cards as links (elastic#45254)
  fix(code/frontend): should show updating instead of cloning when updating (elastic#45238)
  fix(code/frontend): fix document search result from (elastic#45236)
  disable another flaky suite (elastic#45323) (elastic#45330)
  disable flaky suite (elastic#45105)
  skip flaky suite (elastic#43069)
  skip flaky suite (elastic#45089)
  ...
thompsongl added a commit that referenced this pull request Sep 11, 2019
* Upgrade EUI to 13.8.1 (#45052)

* eui to 13.8.0

* euibutton ts updates

* euicontextmenupanel ts updates

* misc ts updates

* src snapshot updates

* x-pack snapshot updates

* 13.8.1

* snapshot update (poor merge conflict resolution)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore release_note:skip Skip the PR/issue when compiling release notes v7.5.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants