Animate EuiAccordion arrow on open #2507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @sqren. The design here is fine. Do you mind if I commit directly and clean up the implementation? Specifically, this should use selectors rather than style attributes, and match against our animation timings. |
|
PR4U against this branch #2509 If you can, try to create branches on your own fork. |
|
I went ahead and merged it. It's the same end result, just a cleaner method. This is OK to review. |
snide
changed the title
arrowRight transition
|
@snide Thanks for fixing this up! LGTM 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses er 90 degree transition instead of fade-in.