Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade EUI to 16.0.0 #50779

Merged
merged 22 commits into from
Nov 20, 2019
Merged

Upgrade EUI to 16.0.0 #50779

merged 22 commits into from
Nov 20, 2019

Conversation

thompsongl
Copy link
Contributor

@thompsongl thompsongl commented Nov 15, 2019 •
edited
Loading

Summary

v14.9.0 ⏩ v16.0.0

Version breaking changes have no real impact on Kibana: Omit was not used, and EUI is behind Kibana's TypeScript version; EuiCardGraphic was also not in use.

The majority of changes in this PR come from EuiSuperDatePicker and EuiDatePicker now fully accommodating dateFormat preference. Previously, absolute date ranges were specified/relayed in ISO format regardless of UI setting. Functional tests had to be updated to account for date formatting changes.

16.0.0

  • Made EuiCard more accessible (#2521)
  • Added ability to pass children to EuiCard (#2521)
  • Replaced root element in EuiFlyout, switching from span to Fragment (#2527)
  • Upgraded react-virtualized to 9.21.2

Bug fixes

  • Added support for timeFormat formatting in EuiSuperDatePicker and fixed some formatting inconsistencies (#2518)
  • Added support for locale in EuiSuperDatePicker and EuiDatePicker both as a prop and from EuiContext (#2518)

Breaking changes

  • Removed EuiCardGraphic (#2521)

15.0.0

  • Converted EuiShowFor and EuiHideFor to TS (#2503)
  • Upgraded react-ace to 7.0.5

Bug fixes

  • Created .euiTableCaption with position: relative to avoid double border under header row (#2484)
  • Fixed EuiSwitch to use aria-labelledby (#2522)
  • Fixed EuiPanelProps type definition (#2516)

Breaking changes

  • Added display modifier to EuiShowFor (#2503)
  • Updated minimum TypeScript version to 3.5.3 (#2510)
  • Removed Omit type in favor of TypeScript's built-in (#2510)

14.10.0

  • Added new euiControlBar component for bottom-of-screen navigational elements. (#2204)
  • Converted EuiFlyout to TypeScript (#2500)
  • Added an animation to the arrow on EuiAccordion as it opens / closes (#2507)
  • Upgraded react-input-autosize to 2.2.2

Bug fixes

  • Simplified EuiColorStops popover toggling (#2505)

@thompsongl thompsongl added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes EUI v7.6.0 labels Nov 15, 2019
@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

@thompsongl
Copy link
Contributor Author

jenkins test this

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

@thompsongl thompsongl marked this pull request as ready for review November 19, 2019 21:24
@thompsongl thompsongl requested review from a team as code owners November 19, 2019 21:24
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

pgayvallet
pgayvallet approved these changes Nov 20, 2019
View reviewed changes
Copy link
Contributor

@pgayvallet pgayvallet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

platform changes LGTM

dgieselaar
dgieselaar reviewed Nov 20, 2019
View reviewed changes
Copy link
Member

@dgieselaar dgieselaar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

APM changes LGTM

weltenwort
weltenwort approved these changes Nov 20, 2019
View reviewed changes
Copy link
Member

@weltenwort weltenwort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

infra changes LGTM

legrego
legrego approved these changes Nov 20, 2019
View reviewed changes
Copy link
Member

@legrego legrego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Security/Spaces changes LGTM

@LeeDr
Copy link
Contributor

LeeDr commented Nov 20, 2019

I thought this PR was going to include at least one test that changed the dateformat setting to the ISO format?

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@elasticmachine
Copy link
Contributor

💔 Build Failed

chandlerprall
chandlerprall approved these changes Nov 20, 2019
View reviewed changes
Copy link
Contributor

@chandlerprall chandlerprall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

package.json & yarn.lock changes LGTM. Spot-checked the functional test changes and they look sane. EuiHideFor/EuiShowFor changes look correct.

@thompsongl
Copy link
Contributor Author

Remaining code owner review requests relate to snapshot updates only. I'll merge this on a successful CI run

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@thompsongl thompsongl merged commit 7cbb072 into elastic:master Nov 20, 2019
@thompsongl thompsongl mentioned this pull request Nov 20, 2019
Merged
thompsongl added a commit to thompsongl/kibana that referenced this pull request Nov 20, 2019
@thompsongl
Upgrade EUI to 16.0.0 (elastic#50779)
bf2db5c 
* eui to 16.0.0

* type defs

* card click

* snapshot updates

* time format test updates

* ts return

* integration fix

* async

* more time format fixes

* more time format fixes

* test updates

* add uisettings dateformat timepicker test

* after method to clear setting
thompsongl added a commit that referenced this pull request Nov 21, 2019
@thompsongl
Upgrade EUI to 16.0.0 (#50779) (#51241)
de03089 
* eui to 16.0.0

* type defs

* card click

* snapshot updates

* time format test updates

* ts return

* integration fix

* async

* more time format fixes

* more time format fixes

* test updates

* add uisettings dateformat timepicker test

* after method to clear setting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgieselaar dgieselaar dgieselaar left review comments

@LeeDr LeeDr LeeDr left review comments

@chandlerprall chandlerprall chandlerprall approved these changes

@weltenwort weltenwort weltenwort approved these changes

@pgayvallet pgayvallet pgayvallet approved these changes

@legrego legrego legrego approved these changes

Assignees
No one assigned
Labels
EUI release_note:skip Skip the PR/issue when compiling release notes v7.6.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@thompsongl @elasticmachine @LeeDr @chandlerprall @dgieselaar @weltenwort @pgayvallet @legrego