Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced root element of EuiFlyout #2527

Merged
merged 3 commits into from
Nov 14, 2019

Conversation

andreadelrio
Copy link
Contributor

Summary

Replaced span with Fragment as the root element of EuiFlyout. Fixes #1488

Checklist

- [ ] Checked in dark mode
- [ ] Checked in mobile
- [ ] Checked in IE11 and Firefox
- [ ] Props have proper autodocs
- [ ] Added documentation examples

  • Added or updated jest tests
    - [ ] Checked for breaking changes and labeled appropriately
    - [ ] Checked for accessibility including keyboard-only and screenreader modes
  • A changelog entry exists and is marked appropriately

Copy link
Contributor

@thompsongl thompsongl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Tested locally and all interactions remain as they were

@cchaos
Copy link
Contributor

cchaos commented Nov 14, 2019

@thompsongl You mentioned in the issue that using Fragment caused issues in certain cases. #1488 (comment)

Is that still the case?

@thompsongl
Copy link
Contributor

@cchaos Nope. At the time of that comment, EUI was still using the old focus trap/lock library. Since updating, the root of the problem is not applicable.

I should've noted that @andreadelrio and I had an Slack conversation about this before she started work here. Thanks for bringing it up here.

Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! Then 👍

@andreadelrio andreadelrio merged commit 751aff1 into elastic:master Nov 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EuiFlyout renders a div inside of a span
3 participants