Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade typescript 3.3.3 -> 3.5.3 #2510

Merged
merged 2 commits into from
Nov 12, 2019
Merged

Upgrade typescript 3.3.3 -> 3.5.3 #2510

merged 2 commits into from
Nov 12, 2019

Conversation

chandlerprall
Copy link
Contributor

@chandlerprall chandlerprall commented Nov 1, 2019 •
edited
Loading

Summary

This is a breaking change

  • Upgraded typescript from 3.3.3 to 3.5.3, necessary for tables' typescript conversion (TypeScriptified basic_table.  #2428)
  • bumped @typescript-eslint/eslint-plugin and @typescript-eslint/parser from 1.9.0 to 1.13.0
  • Removed EUI's definition of Omit in favor of TS's now built-in version

Checklist

- [ ] Checked in dark mode
- [ ] Checked in mobile
- [ ] Checked in IE11 and Firefox
- [ ] Props have proper autodocs
- [ ] Added documentation examples

  • Added or updated jest tests
  • Checked for breaking changes and labeled appropriately
    - [ ] Checked for accessibility including keyboard-only and screenreader modes
  • A changelog entry exists and is marked appropriately

thompsongl
thompsongl approved these changes Nov 1, 2019
View reviewed changes
Copy link
Contributor

@thompsongl thompsongl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Kibana type_check looks good, too, and no EUI Omit imports were found.

@chandlerprall chandlerprall mentioned this pull request Nov 2, 2019
Merged
6 tasks
@chandlerprall chandlerprall merged commit 641732b into elastic:master Nov 12, 2019
@chandlerprall chandlerprall deleted the ts-3.5.3 branch November 12, 2019 21:03
@thompsongl thompsongl mentioned this pull request Nov 15, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thompsongl thompsongl thompsongl approved these changes

Assignees
No one assigned
Labels
typescript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chandlerprall @thompsongl @snide