Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export select option type #2830

Merged
merged 9 commits into from
Feb 10, 2020
Merged

Conversation

mattkime
Copy link
Contributor

@mattkime mattkime commented Feb 6, 2020

Summary

It would be helpful to be able to import the Option type into my kibana code. This is partial work as I'm not sure how what I'm attempting here works with the typedef files. A small nudge should help it across the line.

Checklist

  • Check against all themes for compatibility in both light and dark modes
  • Checked in mobile
  • Checked in IE11 and Firefox
  • Props have proper autodocs
  • Added documentation examples
  • Added or updated jest tests
  • Checked for breaking changes and labeled appropriately
  • Checked for accessibility including keyboard-only and screenreader modes
  • A changelog entry exists and is marked appropriately

src/components/form/select/select.tsx Outdated Show resolved Hide resolved
src/components/form/index.js Outdated Show resolved Hide resolved
src/components/form/index.js Outdated Show resolved Hide resolved
@chandlerprall
Copy link
Contributor

Also needs a CHANGELOG.md entry, like

- Converted `EuiDescribedFormGroup` to TypeScript ([#2810](https://github.com/elastic/eui/pull/2810))

@thompsongl
Copy link
Contributor

jenkins test this

update changelog
changelog entry style
Copy link
Contributor

@chandlerprall chandlerprall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; pulled & tested locally, including eui.d.ts build to confirm the type is exported.

@chandlerprall chandlerprall merged commit 7ba5fd6 into elastic:master Feb 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants