Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade EUI to v20.0.2 #59199

Merged
merged 6 commits into from
Mar 5, 2020
Merged

Upgrade EUI to v20.0.2 #59199

merged 6 commits into from
Mar 5, 2020

Conversation

chandlerprall
Copy link
Contributor

Summary

Contains the usual jest snapshot test updates, as well as some TypeScript updates as EuiCodeEditor and EuiComboBox were converted. Most TypeScript changes are to types and not runtime code, apart from a couple null checks.

20.0.2

Bug fixes

  • Fixed type definitions for EuiComboBox (#2971)

20.0.1

Bug fixes

  • Added TypeScript definition for EuiCodeEditor's accepting react-ace props (#2926)
  • Added @types/react-input-autosize to project's dependencies (#2930)

20.0.0

  • Converted EuiComboBox, EuiComboBoxInput, EuiComboBoxPill, EuiComboBoxOptionsList, EuiComboBoxOption, and EuiComboBoxTitle to TypeScript (#2838)
  • Converted EuiCodeEditor to TypeScript (#2836)
  • Converted EuiCode and EuiCodeBlock and to TypeScript (#2835)
  • Converted EuiFilePicker to TypeScript (#2832)
  • Exported EuiSelectOptionProps type (#2830)
  • Added paperClip glyph to EuiIcon (#2845)
  • Added banner prop to EuiFlyoutBody and updated euiOverflowShadow mixin (#2837)
  • Updated editorLink icon (#2866)
  • Added control columns to EuiDataGrid to support non-data columns like row selection and actions (#2846)
  • Added image glyph to EuiIcon (#2870)
  • Exported TS props from top level EuiListGroupProps, EuiListGroupItemProps, EuiSelectableProps, EuiSelectableOption, EuiSelectableOptionsListProps (#2869)
  • Extending EuiSelectable[options] type with correct HTML element (#2869)
  • Added check mark to single selection EuiComboBox (#2890)
  • Added logoGoogleG third-party logo to EuiIcon (#2853)
  • Added Jest modulesNameMapper alias for EuiIcon using test environment mock (#2878)
  • Removed sinon and @types/sinon as dependencies, and converted usages to jest.fn (#2885)

Bug fixes

  • Fixed building dev & docs on Windows (#2847)
  • Fixed screen reader discovery issues with EuiBottomBar and EuiControlBar (#2861)
  • Fixed a bug in EuiDataGrid causing the first cell to autofocus if interactive (#2872)

Breaking changes

  • Removed visControls and visHeatmap duplicate icons from docs (#2908)

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@chandlerprall chandlerprall added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.7.0 labels Mar 3, 2020
@chandlerprall chandlerprall requested a review from a team as a code owner March 3, 2020 18:44
@chandlerprall chandlerprall requested a review from a team March 3, 2020 18:44
@chandlerprall chandlerprall requested review from a team as code owners March 3, 2020 18:44
@legrego legrego requested review from legrego and a team and removed request for a team March 3, 2020 19:04
legrego
legrego approved these changes Mar 3, 2020
View reviewed changes
Copy link
Member

@legrego legrego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Security/Spaces changes LGTM - tested locally.

spalger
spalger approved these changes Mar 3, 2020
View reviewed changes
Copy link
Contributor

@spalger spalger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kbn/ui-shared-deps update LGTM

@YulNaumenko YulNaumenko requested review from YulNaumenko and a team March 3, 2020 22:11
lizozom
lizozom approved these changes Mar 4, 2020
View reviewed changes
Copy link
Contributor

@lizozom lizozom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

App Arch changes LGTM

walterra
walterra approved these changes Mar 4, 2020
View reviewed changes
Copy link
Contributor

@walterra walterra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ML & transform changes LGTM

@Dosant Dosant mentioned this pull request Mar 4, 2020
Closed
7 tasks
weltenwort
weltenwort reviewed Mar 4, 2020
View reviewed changes
Copy link
Member

@weltenwort weltenwort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀 Reviewing on behalf of @elastic/logs-metrics-ui...

YulNaumenko
YulNaumenko approved these changes Mar 4, 2020
View reviewed changes
Copy link
Contributor

@YulNaumenko YulNaumenko left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I've posted a question about removing isInvalid for EuiCodeEditor.

weltenwort
weltenwort approved these changes Mar 4, 2020
View reviewed changes
Copy link
Member

@weltenwort weltenwort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

infra changes LGTM

igoristic
igoristic approved these changes Mar 4, 2020
View reviewed changes
Copy link
Contributor

@igoristic igoristic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good with Stack Monitoring, and all tests seem to be passing 👍

poffdeluxe
poffdeluxe approved these changes Mar 5, 2020
View reviewed changes
Copy link
Contributor

@poffdeluxe poffdeluxe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

canvas changes seem to work just fine 👍

thompsongl
thompsongl approved these changes Mar 5, 2020
View reviewed changes
Copy link
Contributor

@thompsongl thompsongl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TS and snapshot changes LGTM; spot-checked locally

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

  • 💚 Build #30998 succeeded 0a1c55f18ea352cabf321e7a0c78c7bc4ab37d33
  • 💔 Build #30808 failed 9ca47af837032b510330e9c7e5dc52ef63f0202b
  • 💔 Build #30474 failed dca18ad528f1ff4859ae5c2a704f7b82c802250e

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@chandlerprall chandlerprall merged commit 096dda6 into elastic:master Mar 5, 2020
@chandlerprall chandlerprall mentioned this pull request Mar 5, 2020
Merged
chandlerprall added a commit to chandlerprall/kibana that referenced this pull request Mar 5, 2020
@chandlerprall
Upgrade EUI to v20.0.2 (elastic#59199)
e88d4a6 
* Updated EUI to 20.0.1; updated typescript usage

* snapshots

* Upgrade to eui 20.0.2, fix one more type

* PR feedback

* Update EUI icon usage to the correct types

* Updated with master
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Mar 6, 2020
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

@chandlerprall chandlerprall deleted the eui-20-0-2 branch March 6, 2020 19:46
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Mar 6, 2020
chandlerprall added a commit that referenced this pull request Mar 6, 2020
@chandlerprall
[7.x] Upgrade EUI to v20.0.2 (#59199) (#59477)
2b9c10b 
* Upgrade EUI to v20.0.2 (#59199)

* Updated EUI to 20.0.1; updated typescript usage

* snapshots

* Upgrade to eui 20.0.2, fix one more type

* PR feedback

* Update EUI icon usage to the correct types

* Updated with master

* Fixed a missing import
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YulNaumenko YulNaumenko YulNaumenko approved these changes

@igoristic igoristic igoristic approved these changes

@myasonik myasonik myasonik approved these changes

@legrego legrego legrego approved these changes

@lizozom lizozom lizozom approved these changes

@thompsongl thompsongl thompsongl approved these changes

@spalger spalger spalger approved these changes

@weltenwort weltenwort weltenwort approved these changes

@poffdeluxe poffdeluxe poffdeluxe approved these changes

@walterra walterra walterra approved these changes

Assignees
No one assigned
Labels
release_note:skip Skip the PR/issue when compiling release notes v7.7.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.