Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update editorLink icon #2866

Merged
merged 5 commits into from
Feb 20, 2020
Merged

Conversation

miukimiu
Copy link
Contributor

@miukimiu miukimiu commented Feb 18, 2020

Summary

The editorLink icon looks thinner when compared with other editor icons. This PR updates it to make it look thicker.

EditorLink Icon@2x

Checklist

  • Check against all themes for compatibility in both light and dark modes
  • [ ] Checked in mobile
  • [ ] Checked in IE11 and Firefox
  • [ ] Props have proper autodocs
  • [ ] Added documentation examples
  • [ ] Added or updated jest tests
  • [ ] Checked for breaking changes and labeled appropriately
  • [ ] Checked for accessibility including keyboard-only and screenreader modes
  • A changelog entry exists and is marked appropriately

@miukimiu miukimiu changed the title Improve editorLink icon Update editorLink icon Feb 18, 2020
@cchaos
Copy link
Contributor

cchaos commented Feb 18, 2020

Thanks so much for fixing this one! Can you also add a screenshot with the pixel grid?

@miukimiu
Copy link
Contributor Author

miukimiu commented Feb 19, 2020

@Caroline here's the screenshot with the pixel grid:

Screenshot 2020-02-19 at 13 05 57

The editor icons are inside the 16px square but they have a 10px height. So I created my own grid margins.

@cchaos
Copy link
Contributor

cchaos commented Feb 19, 2020

Just being super nit picky here, but I'd assume that these areas should be inside the pixel lines?

Screen Shot 2020-02-19 at 09 40 38 AM

@miukimiu
Copy link
Contributor Author

Now the areas are inside the pixel lines:

Screenshot 2020-02-19 at 19 49 33

@miukimiu miukimiu requested a review from cchaos February 19, 2020 20:16
Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making that change! 👍 LGTM!

@miukimiu miukimiu merged commit 3ab9d6f into elastic:master Feb 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants