-
Notifications
You must be signed in to change notification settings - Fork 841
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update editorLink icon #2866
Update editorLink icon #2866
Conversation
Thanks so much for fixing this one! Can you also add a screenshot with the pixel grid? |
@Caroline here's the screenshot with the pixel grid: The editor icons are inside the 16px square but they have a 10px height. So I created my own grid margins. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making that change! 👍 LGTM!
Summary
The
editorLink
icon looks thinner when compared with other editor icons. This PR updates it to make it look thicker.Checklist
[ ] Checked in mobile[ ] Checked in IE11 and Firefox[ ] Props have proper autodocs[ ] Added documentation examples[ ] Added or updated jest tests[ ] Checked for breaking changes and labeled appropriately[ ] Checked for accessibility including keyboard-only and screenreader modes