Add paper clip glyph to EuiIcon #2845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cchaos
approved these changes
Feb 12, 2020
There was a problem hiding this comment.
👍 LGTM! It's one of the harder icons to completely align to the pixel grid but you did a good job at least getting he outer ring aligned.
I also polled about paperClip vs paperclip and it was pretty split though with a slight lean towards the former so 👍 on naming as well.
andreadelrio
pushed a commit
to andreadelrio/eui
that referenced
this pull request
Feb 12, 2020
* Adding paper clip glyph to EuiIcon * Adding changelog
2 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #2840
This PR adds a paper clip glyph to
EuiIcon.Paper clip icon in dark and light theme
Paper clip icon near other icons
Design
Checklist
Checked in mobileChecked in IE11 and FirefoxProps have proper autodocsChecked for breaking changes and labeled appropriatelyChecked for accessibility including keyboard-only and screenreader modes