Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SIEM Case Icons #2935

Merged
merged 6 commits into from
Feb 26, 2020
Merged

Conversation

MichaelMarcialis
Copy link
Contributor

@MichaelMarcialis MichaelMarcialis commented Feb 26, 2020

Summary

Added new icons to EUI to support the needs of the upcoming SIEM case workflow integration feature. Including the following icons:

  • folderCheck
  • folderExclamation
    - logoServicenow
  • push
  • quote
  • reporter
  • users

Issue

image

Checklist

  • Check against all themes for compatibility in both light and dark modes
    - [ ] Checked in mobile
  • Checked in IE11 and Firefox
    - [ ] Props have proper autodocs
  • Added documentation examples
  • Added or updated jest tests
    - [ ] Checked for breaking changes and labeled appropriately
    - [ ] Checked for accessibility including keyboard-only and screenreader modes
  • A changelog entry exists and is marked appropriately

@MichaelMarcialis MichaelMarcialis marked this pull request as ready for review February 26, 2020 16:00
@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_2935/

@MichaelMarcialis MichaelMarcialis changed the title Siem case icons SIEM Case Icons Feb 26, 2020
@cchaos
Copy link
Contributor

cchaos commented Feb 26, 2020

I mentioned in slack that we'd like to not add more third-party logos if possible since EuiIcon can support custom SVG's.

Also, I've checked these on a non-retina screen and while the new case_ icons match our folder icons, all of them are blurry in this area on non-retina when I really think they don't need to be.

Screen Shot 2020-02-26 at 11 19 51 AM

Other than that, the designs of the icons look great. My only other thought goes towards naming.

I'd propose the following:

  • people -> users: We already have a user icon and it would be nice to just make this one the plural version.
  • case_open -> folderExclamation: Both case_ icons are just folders with extra indicators, I'd label them as such, since we try to be explanatory of what the icon is and not what it represents. That way they're more generalized for universal usage.
  • case_closed -> folderCheck: Same reason above

@MichaelMarcialis
Copy link
Contributor Author

Thanks for the comments, @cchaos!

I mentioned in slack that we'd like to not add more third-party logos if possible since EuiIcon can support custom SVG's.

Ah, sorry about that. I've removed it and will notify my engineers to use a custom SVG.

Also, I've checked these on a non-retina screen and while the new case_ icons match our folder icons, all of them are blurry in this area on non-retina when I really think they don't need to be.

Yeah, I noticed that when repurposing the older folder icons. I've updated both the new and old folder icons to sit better on the pixel grid.

My only other thought goes towards naming.

All updated, per your recommendations. Thanks, again!

Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making those changes! Just waiting for the build to test visually again. Found a quick issue with the CL

CHANGELOG.md Outdated Show resolved Hide resolved
@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_2935/

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_2935/

Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@MichaelMarcialis MichaelMarcialis merged commit 5348a47 into elastic:master Feb 26, 2020
@MichaelMarcialis MichaelMarcialis deleted the siem-case-icons branch February 26, 2020 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants