[babel] use babel-runtime+transform-runtime to support async functions #304
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using async functions and targeting runtimes that don't support generators means that eui must depend on regenerator. Without it the
test/syncify.js
helper throwsReferenceError: regeneratorRuntime is not defined
when installed as a node modules.This pr includes the
transform-runtime
babel plugin which will rewrite access to theregeneratorRuntime
global with calls torequire("babel-runtime/regenerator")
, which is now listed as a dependency of eui. This does add a fairly sizable dependency for one async function, but since Kibana is also using regenerator it should only get included in the bundles once.Alternatively we can disallow async functions in eslint config and convert the syncify helper to use standard promises.