Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade react deps #16025

Merged
merged 6 commits into from
Jan 17, 2018
Merged

Upgrade react deps #16025

merged 6 commits into from
Jan 17, 2018

Conversation

spalger
Copy link
Contributor

@spalger spalger commented Jan 12, 2018

Upgrades our react deps and eui to ensure that only one version of react is used everywhere. All upgrades are within the same major version, so we should be able to avoid breaking changes.

@spalger spalger added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v7.0.0 v6.2.0 labels Jan 12, 2018
@spalger
Copy link
Contributor Author

spalger commented Jan 12, 2018

react-input-autosize was removed because it was only added to fix a bug that is now fixed upstream

@spalger
Copy link
Contributor Author

spalger commented Jan 12, 2018

react-sortable was removed because there is no indication of it being used.

@spalger spalger changed the title Upgrade/react deps Upgrade react deps Jan 12, 2018
@spalger spalger requested a review from kimjoar January 12, 2018 22:37
@spalger spalger added the review label Jan 12, 2018
@spalger
Copy link
Contributor Author

spalger commented Jan 12, 2018

Blocked on elastic/eui#304

@spalger spalger force-pushed the upgrade/react-deps branch from 436e601 to 3e393e4 Compare January 16, 2018 23:02
@spalger spalger force-pushed the upgrade/react-deps branch from 3e393e4 to 871414a Compare January 16, 2018 23:05
@spalger
Copy link
Contributor Author

spalger commented Jan 17, 2018

jenkins, test this

@kimjoar kimjoar merged commit 215d9a0 into elastic:master Jan 17, 2018
kimjoar pushed a commit to kimjoar/kibana that referenced this pull request Jan 17, 2018
* [yarn] upgrade react deps

* [yarn] reinstall pivotal-ui so that react dep is deduped

* [yarn] remove unused deps

* [react-ace] update snapshots to include new aria props

* [react-input-range] update snapshot with new allowSameValues prop, default is still false

* [react-select] update snapshots with new default from features added since 1.0.0-rc5
kimjoar added a commit that referenced this pull request Jan 17, 2018
* [yarn] upgrade react deps

* [yarn] reinstall pivotal-ui so that react dep is deduped

* [yarn] remove unused deps

* [react-ace] update snapshots to include new aria props

* [react-input-range] update snapshot with new allowSameValues prop, default is still false

* [react-select] update snapshots with new default from features added since 1.0.0-rc5
@spalger spalger deleted the upgrade/react-deps branch February 9, 2018 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v6.2.0 v7.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants