shifting makeId to htmlIdGenerator #3129
Conversation
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
|
💚 CLA has been signed |
|
Note that this does not close #3112 as there are many other places where |
Hey, |
|
Jenkins test this |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3129/ |
No worries at all! I took a second pass and left a couple more comments. |
|
jenkins test this |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3129/ |
ghost
mentioned this pull request
|
Hi @chandlerprall this PR is getting a lot of conflicting files due to the class to functional components conversions. Should we fix the conflicts and merge the PR? |
package.json
Outdated
| @@ -57,6 +57,7 @@ | |||
| "classnames": "^2.2.5", | |||
| "highlight.js": "^9.12.0", | |||
| "html": "^1.0.0", | |||
| "install": "^0.13.0", | |||
There was a problem hiding this comment.
I guess it is some form of merge conflict.
Wait i'll remove it as it is not required by changes I've made
|
@NightWing1998 I merged master directly into your fork and cleaned up the conflicts we had introduced; running CI, will merge if everything's green jenkins test this |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_3129/ |
Summary
Summarize your PR. If it includes design elements include a screenshot or gif.
deprecating makeId and shifting the codebase to htmlIdGenerator.
This invalids make_id.test.ts file as the make_id is of no use anymore
Fixes #3112
Checklist
A changelog entry exists and is marked appropriately