Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Converted form control component examples to functional component #3242

Merged
merged 9 commits into from Apr 3, 2020
Merged

[DOCS] Converted form control component examples to functional component #3242

merged 9 commits into from Apr 3, 2020

Conversation

ghost
Copy link

@ghost ghost commented Apr 3, 2020

Summary

Progress on #3150

@kibanamachine
Copy link

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@miukimiu miukimiu changed the title Update checkbox.js [Docs] Converted form control component examples to functional component Apr 3, 2020
@miukimiu miukimiu self-requested a review April 3, 2020 11:51
@miukimiu miukimiu added the documentation Issues or PRs that only affect documentation - will not need changelog entries label Apr 3, 2020
@miukimiu
Copy link
Contributor

miukimiu commented Apr 3, 2020

jenkins test this

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_3242/

@miukimiu
Copy link
Contributor

miukimiu commented Apr 3, 2020

jenkins test this

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_3242/

@ghost
Copy link
Author

ghost commented Apr 3, 2020

2

PR #3129 is working on shifting the makeId to htmlIdGenerator, I guess.
Will always use arrow functions from now onwards!

Copy link
Contributor

@miukimiu miukimiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @walter-ind! 🎉

I tested the Demo and Demo JS tabs and all of them look good!

There's no need for the PR #3129 because I fixed the issue with the commit 8e37b86. We can't merge issues with errors.

@miukimiu miukimiu merged commit b5752fc into elastic:master Apr 3, 2020
@NightWing1998
Copy link

Thanks, @walter-ind! 🎉

I tested the Demo and Demo JS tabs and all of them look good!

There's no need for the PR #3129 because I fixed the issue with the commit 8e37b86. We can't merge issues with errors.

But you have only changed the components inside form_controls to htmlIdGenerator where as there are other components as well which are using them

@miukimiu
Copy link
Contributor

miukimiu commented Apr 3, 2020

Yes, @NightWing1998 you're right. Your PR fixes much more components.

When I said there's no need for PR #3129 I was trying to say that to merge this PR (#3242) we don't need to wait on #3129. 🙂

@NightWing1998
Copy link

Yes, @NightWing1998 you're right. Your PR fixes much more components.

When I said there's no need for PR #3129 I was trying to say that to merge this PR (#3242) we don't need to wait on #3129. 🙂

Ohh my bad😅

@ghost ghost changed the title [Docs] Converted form control component examples to functional component [DOCS] Converted form control component examples to functional component Apr 7, 2020
@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_3242/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Issues or PRs that only affect documentation - will not need changelog entries
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants