Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Converted form control component examples to functional component #3228

Closed
wants to merge 8 commits into from
Closed

[DOCS] Converted form control component examples to functional component #3228

wants to merge 8 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Apr 2, 2020

Summary

Makes progress on #3150

@kibanamachine
Copy link

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@ghost ghost changed the title Update checkbox.js [DOCS] Converted form-control class component to functional component Apr 2, 2020
@snide
Copy link
Contributor

snide commented Apr 2, 2020

jenkins test this

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_3228/

@cchaos cchaos changed the title [DOCS] Converted form-control class component to functional component [Docs] Converted form control component examples to functional component Apr 3, 2020
@cchaos cchaos added the documentation Issues or PRs that only affect documentation - will not need changelog entries label Apr 3, 2020
@cchaos
Copy link
Contributor

cchaos commented Apr 3, 2020

Jenkins test this

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_3228/

@miukimiu miukimiu self-requested a review April 3, 2020 11:04
@miukimiu
Copy link
Contributor

miukimiu commented Apr 3, 2020

Hi @walter-ind,

I'm closing this issue in favor of #3242

Also because there's the unknown repository issue with the PR :
Screenshot 2020-04-03 at 12 29 59

@miukimiu miukimiu closed this Apr 3, 2020
@ghost ghost changed the title [Docs] Converted form control component examples to functional component [DOCS] Converted form control component examples to functional component Apr 7, 2020
@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_3228/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Issues or PRs that only affect documentation - will not need changelog entries
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants