Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add download glyph to EuiIcon #3364

Merged
merged 6 commits into from
Apr 23, 2020
Merged

Conversation

miukimiu
Copy link
Contributor

@miukimiu miukimiu commented Apr 21, 2020

Summary

Closes #3361.

  • This PR adds a download glyph to EuiIcon.
  • I'm using the same arrow from the export and share glyphs. So for consistency, I did not change its size.

Dark and light themes

download-icon-themes@2x

Design

Screenshot 2020-04-22 at 19 06 55

Checklist

  • Check against all themes for compatibility in both light and dark modes
  • Checked in mobile
  • Checked in IE11 and Firefox
  • Props have proper autodocs
  • Added documentation examples
  • Added or updated jest tests
  • Checked for breaking changes and labeled appropriately
  • Checked for accessibility including keyboard-only and screenreader modes
  • A changelog entry exists and is marked appropriately

@miukimiu miukimiu requested a review from cchaos April 21, 2020 12:34
@cchaos
Copy link
Contributor

cchaos commented Apr 21, 2020

Are we worried that there might be conflict between the understanding of this icon and the current importAction?
Screen Shot 2020-04-21 at 08 48 38 AM

They're very similar but mean very different things.

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_3364/

@snide
Copy link
Contributor

snide commented Apr 21, 2020

We discussed this today in our meeting. We decided it's OK to have them slightly different. There might be a followup to change the "export" icon to separate these concerns a little bit more.

1 similar comment
@snide
Copy link
Contributor

snide commented Apr 21, 2020

We discussed this today in our meeting. We decided it's OK to have them slightly different. There might be a followup to change the "export" icon to separate these concerns a little bit more.

@cchaos
Copy link
Contributor

cchaos commented Apr 22, 2020

The one thing you'll want to tweak here is that the main line of the arrow cannot straddle 2 pixels. It has to align inside. This will make your icon not be fully center and 1px smaller than the whole artboard, but that is ok. The straddling will make the line very fuzzy for non-retina screens. Here's the example from the import icon

Screen Shot 2020-04-22 at 09 55 28 AM

Also, don't forget to add this to the Figma EUI icon set.

@miukimiu
Copy link
Contributor Author

@cchaos I've tweaked the icon.

Now the download icon is not centered anymore but the main line of the arrow is not straddling. Based on other similar icons I also left a 1px space below the icon.

I also added the icon to the Figma icon set and updated the PR description with new screenshots.

Screenshot 2020-04-22 at 19 21 37

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_3364/

Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks great. I checked it out on a non-retina screen too.

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_3364/

@miukimiu miukimiu merged commit 9e17bcf into elastic:master Apr 23, 2020
@nicolapagni
Copy link

Hi,

since the icon should be merged into the master, using @elastic/eui 24.0.0 and using this type of icon I don't see that correctly.
download-icon-error

@miukimiu
Copy link
Contributor Author

miukimiu commented Jun 3, 2020

Hi @nicolapagni,

Thank you for reporting this error. Can you please open an issue and specify with a code example how are you using the icon?

Thanks!

@nicolapagni
Copy link

@miukimiu done.

#3543

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Icons] Icon request: "download" icon
5 participants