-
Notifications
You must be signed in to change notification settings - Fork 841
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add download glyph to EuiIcon #3364
Conversation
Preview documentation changes for this PR: https://eui.elastic.co/pr_3364/ |
We discussed this today in our meeting. We decided it's OK to have them slightly different. There might be a followup to change the "export" icon to separate these concerns a little bit more. |
1 similar comment
We discussed this today in our meeting. We decided it's OK to have them slightly different. There might be a followup to change the "export" icon to separate these concerns a little bit more. |
The one thing you'll want to tweak here is that the main line of the arrow cannot straddle 2 pixels. It has to align inside. This will make your icon not be fully center and 1px smaller than the whole artboard, but that is ok. The straddling will make the line very fuzzy for non-retina screens. Here's the example from the import icon Also, don't forget to add this to the Figma EUI icon set. |
@cchaos I've tweaked the icon. Now the download icon is not centered anymore but the main line of the arrow is not straddling. Based on other similar icons I also left a 1px space below the icon. I also added the icon to the Figma icon set and updated the PR description with new screenshots. |
Preview documentation changes for this PR: https://eui.elastic.co/pr_3364/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks great. I checked it out on a non-retina screen too.
Preview documentation changes for this PR: https://eui.elastic.co/pr_3364/ |
Hi @nicolapagni, Thank you for reporting this error. Can you please open an issue and specify with a code example how are you using the icon? Thanks! |
Summary
Closes #3361.
Dark and light themes
Design
Checklist
Checked in mobileChecked in IE11 and FirefoxProps have proper autodocsChecked for breaking changes and labeled appropriatelyChecked for accessibility including keyboard-only and screenreader modes