Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add download glyph to EuiIcon #3364

Merged
merged 6 commits into from
Apr 23, 2020
Merged

Add download glyph to EuiIcon #3364

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
8fd96ce
Adding download glyph to EuiIcon
miukimiu Apr 21, 2020
d1f9086
Updating changelog with PR number
miukimiu Apr 21, 2020
a88edb2
Merge remote-tracking branch 'upstream/master' into download-icon
miukimiu Apr 22, 2020
a0b6700
Improving icon
miukimiu Apr 22, 2020
943b6b3
Updating test
miukimiu Apr 22, 2020
fdf47ee
Merge remote-tracking branch 'upstream/master' into download-icon
miukimiu Apr 23, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
## [`master`](https://github.com/elastic/eui/tree/master)

- Added `download` glyph to `EuiIcon` ([#3364](https://github.com/elastic/eui/pull/3364))
- Applies `max-width: 100%` to `EuiPageBody` so inner flex-based items don't overflow their containers ([#3375](https://github.com/elastic/eui/pull/3375))

## [`23.1.0`](https://github.com/elastic/eui/tree/v23.1.0)
Expand Down
1 change: 1 addition & 0 deletions src-docs/src/views/icon/icons.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,7 @@ export const iconTypes = [
'documentEdit',
'documents',
'dot',
'download',
'email',
'empty',
'exit',
Expand Down
20 changes: 20 additions & 0 deletions src/components/icon/__snapshots__/icon.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1628,6 +1628,26 @@ exports[`EuiIcon props type dot is rendered 1`] = `
</svg>
`;

exports[`EuiIcon props type download is rendered 1`] = `
<svg
aria-hidden="true"
class="euiIcon euiIcon--medium euiIcon-isLoaded"
focusable="false"
height="16"
role="img"
viewBox="0 0 16 16"
width="16"
xmlns="http://www.w3.org/2000/svg"
>
<path
d="M9 9.114l1.85-1.943a.52.52 0 01.77 0c.214.228.214.6 0 .829l-1.95 2.05a1.552 1.552 0 01-2.31 0L5.41 8a.617.617 0 010-.829.52.52 0 01.77 0L8 9.082V.556C8 .249 8.224 0 8.5 0s.5.249.5.556v8.558z"
/>
<path
d="M16 13.006V10h-1v3.006a.995.995 0 01-.994.994H3.01a.995.995 0 01-.994-.994V10h-1v3.006c0 1.1.892 1.994 1.994 1.994h10.996c1.1 0 1.994-.893 1.994-1.994z"
/>
</svg>
`;

exports[`EuiIcon props type editorAlignCenter is rendered 1`] = `
<svg
aria-hidden="true"
Expand Down
17 changes: 17 additions & 0 deletions src/components/icon/assets/download.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
import React from 'react';

const EuiIconDownload = ({ title, titleId, ...props }) => (
<svg
width={16}
height={16}
viewBox="0 0 16 16"
xmlns="http://www.w3.org/2000/svg"
aria-labelledby={titleId}
{...props}>
{title ? <title id={titleId}>{title}</title> : null}
<path d="M9 9.114l1.85-1.943a.52.52 0 01.77 0c.214.228.214.6 0 .829l-1.95 2.05a1.552 1.552 0 01-2.31 0L5.41 8a.617.617 0 010-.829.52.52 0 01.77 0L8 9.082V.556C8 .249 8.224 0 8.5 0s.5.249.5.556v8.558z" />
<path d="M16 13.006V10h-1v3.006a.995.995 0 01-.994.994H3.01a.995.995 0 01-.994-.994V10h-1v3.006c0 1.1.892 1.994 1.994 1.994h10.996c1.1 0 1.994-.893 1.994-1.994z" />
</svg>
);

export const icon = EuiIconDownload;
4 changes: 4 additions & 0 deletions src/components/icon/assets/download.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
1 change: 1 addition & 0 deletions src/components/icon/icon.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,7 @@ const typeToPathMap = {
documentEdit: 'documentEdit',
documents: 'documents',
dot: 'dot',
download: 'download',
editorAlignCenter: 'editor_align_center',
editorAlignLeft: 'editor_align_left',
editorAlignRight: 'editor_align_right',
Expand Down