-
Notifications
You must be signed in to change notification settings - Fork 841
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Amsterdam] Remove borders from flyouts and popover arrows #3477
[Amsterdam] Remove borders from flyouts and popover arrows #3477
Conversation
Working on the checklist before moving out of draft status |
Preview documentation changes for this PR: https://eui.elastic.co/pr_3477/ |
Preview documentation changes for this PR: https://eui.elastic.co/pr_3477/ |
Preview documentation changes for this PR: https://eui.elastic.co/pr_3477/ |
Easier override of border with variable
Change template %eui-flyout to mixin euiFlyout
Just making note here that |
Preview documentation changes for this PR: https://eui.elastic.co/pr_3477/ |
I added |
Preview documentation changes for this PR: https://eui.elastic.co/pr_3477/ |
Preview documentation changes for this PR: https://eui.elastic.co/pr_3477/ |
@cchaos Ready for another round/review! 😁 |
Preview documentation changes for this PR: https://eui.elastic.co/pr_3477/ |
That's really weird—I had that issue at one point and fixed it and now I can't reproduce it. Is your display scaled at all? |
No, and I just used the build link above in Chrome. |
You might just want to overcompensate? |
I increased the arrow compensation by 1 in order to overcompensate. Let me know if that fixes it for you. I was still having trouble re-producing. |
Preview documentation changes for this PR: https://eui.elastic.co/pr_3477/ |
Preview documentation changes for this PR: https://eui.elastic.co/pr_3477/ |
^^ That seemed to work 🎉 @johnbarrierwilson Do you want to do a final pass on the shadow again? |
Preview documentation changes for this PR: https://eui.elastic.co/pr_3477/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 LGTM!
Preview documentation changes for this PR: https://eui.elastic.co/pr_3477/ |
Sweet! Looks good on my end! Thanks @cchaos! |
Summary
A. Removes the left border on flyouts to better match other Amsterdam aesthetics.
Flyout
B. Also removes the borders from popover arrows while improving the aesthetic to better match the drop shadow of the related panel.
Bottom
Top
Left
Right
Checklist
- [ ] Props have proper autodocs- [ ] Added documentation examples- [ ] Added or updated jest tests- [ ] Checked for accessibility including keyboard-only and screenreader modes