Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Amsterdam] Remove borders from flyouts and popover arrows #3477

Merged
merged 20 commits into from
May 29, 2020
Merged
Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,15 @@
- Changed parameters for `euiPaletteColorBlind()` to an object ([#3387](https://github.com/elastic/eui/pull/3387))
- Changed the default palette of `EUI_CHARTS_THEME_LIGHT/DARK` themes to the naturally sorted `euiPaletteColorBlind()` ([#3387](https://github.com/elastic/eui/pull/3387))

**Theme: Amsterdam**

- Updates shadow styles to improve smoothness and their appearance on a variety of backgrounds ([#3428](https://github.com/elastic/eui/pull/3428))
- The shadows now default to using black as their base color rather than a dark-tinted blueish color ([#3428](https://github.com/elastic/eui/pull/3428))
- Sets a warning that the opacity variable will be deprecated ([#3428](https://github.com/elastic/eui/pull/3428))
- Opacity values for dark themes are calculated based off a base value ([#3428](https://github.com/elastic/eui/pull/3428))
- Removes borders from left side of flyouts ([#3477](https://github.com/elastic/eui/pull/3477))
- Removes borders from popover arrows ([#3477](https://github.com/elastic/eui/pull/3477))
johnbarrierwilson marked this conversation as resolved.
Show resolved Hide resolved

## [`23.3.0`](https://github.com/elastic/eui/tree/v23.3.0)

- Added `aria-hidden = true` to `EuiRangeSlider` and `EuiRangeTrack` if `showInput = true` ([#3423](https://github.com/elastic/eui/pull/3423))
Expand Down
3 changes: 3 additions & 0 deletions src/themes/eui-amsterdam/overrides/_flyout.scss
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
.euiFlyout {
border-left: none;
}
2 changes: 2 additions & 0 deletions src/themes/eui-amsterdam/overrides/_index.scss
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
@import 'button';
@import 'button_empty';
@import 'button_group';
@import 'flyout';
@import 'popover';
@import 'text';
59 changes: 59 additions & 0 deletions src/themes/eui-amsterdam/overrides/_popover.scss
Original file line number Diff line number Diff line change
@@ -0,0 +1,59 @@
.euiPopover__panel {
.euiPopover__panelArrow {
&:before {
filter: blur(3px);
}

&.euiPopover__panelArrow--top {
&:before {
bottom: -$euiPopoverArrowSize;
border-top-color: $euiColorInk;
opacity: .2;
clip: rect(0, $euiPopoverArrowSize * 2 + 5px, $euiPopoverArrowSize + 5px, -5px);
}

&:after {
bottom: -$euiPopoverArrowSize;
}
}

&.euiPopover__panelArrow--right {
&:before {
left: -$euiPopoverArrowSize;
border-right-color: $euiColorInk;
opacity: .2;
clip: rect(-5px, $euiPopoverArrowSize, $euiPopoverArrowSize * 2 + 5px, -5px);
}

&:after {
left: -$euiPopoverArrowSize;
}
}

&.euiPopover__panelArrow--bottom {
&:before {
top: -$euiPopoverArrowSize;
border-bottom-color: $euiColorInk;
opacity: .2;
clip: rect(-5px, $euiPopoverArrowSize * 2 + 5px, $euiPopoverArrowSize, -5px);
}

&:after {
top: -$euiPopoverArrowSize;
}
}

&.euiPopover__panelArrow--left {
&:before {
right: -$euiPopoverArrowSize;
border-left-color: $euiColorInk;
opacity: .2;
clip: rect(-5px, $euiPopoverArrowSize + 5px, $euiPopoverArrowSize * 2 + 5px, 0);
}

&:after {
right: -$euiPopoverArrowSize;
}
}
}
}