Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added side property to 'EuiGlobalToastList' #3600

Merged
merged 8 commits into from
Jun 15, 2020
Merged

Added side property to 'EuiGlobalToastList' #3600

merged 8 commits into from
Jun 15, 2020

Conversation

shrey
Copy link
Contributor

@shrey shrey commented Jun 11, 2020 •
edited by cchaos
Loading

Summary

Added the side property to EuiGlobalToastList to allow the user to place the toasts left or right instead of just the default right

Checklist

  • [ ] Check against all themes for compatibility in both light and dark modes
  • [ ] Checked in mobile
  • Checked in IE11 and Firefox
  • Props have proper autodocs
  • [ ] Added documentation
  • [ ] Checked Code Sandbox works for the any docs examples
  • Added or updated jest tests
  • [ ] Checked for breaking changes and labeled appropriately
  • [ ] Checked for accessibility including keyboard-only and screenreader modes
  • A changelog entry exists and is marked appropriately

fixes #3435
@cchaos @chandlerprall

@kibanamachine
Copy link

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

anishagg17
anishagg17 reviewed Jun 12, 2020
View reviewed changes
Copy link
Contributor

@anishagg17 anishagg17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can have a new test for this prop

@shrey
Copy link
Contributor Author

shrey commented Jun 12, 2020

@anishagg17 just the snapshot tests, right?

@anishagg17
Copy link
Contributor

@anishagg17 just the snapshot tests, right?

Yep !

@shrey
Copy link
Contributor Author

shrey commented Jun 12, 2020

@anishagg17 updated the test and the snapshot :)

cchaos
cchaos suggested changes Jun 12, 2020
View reviewed changes
Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for starting on another @shrey! This one will need a little bit more work to get over the line.

src/components/toast/global_toast_list.test.tsx Outdated Show resolved Hide resolved
src/components/toast/global_toast_list.tsx Outdated Show resolved Hide resolved
src/components/toast/global_toast_list.tsx Outdated Show resolved Hide resolved
@shrey
Copy link
Contributor Author

shrey commented Jun 12, 2020

@cchaos Done

cchaos
cchaos suggested changes Jun 12, 2020
View reviewed changes
Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Getting closer. A few more tweaks. Also don't forget to add a changelog entry

src/components/toast/global_toast_list.test.tsx Outdated Show resolved Hide resolved
src/components/toast/global_toast_list.tsx Show resolved Hide resolved
src/components/toast/global_toast_list.tsx Outdated Show resolved Hide resolved
@shrey
Copy link
Contributor Author

shrey commented Jun 12, 2020

@cchaos Updated changes, could you review them?

@cchaos
Copy link
Contributor

cchaos commented Jun 12, 2020

Jenkins, test this

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_3600/

@shrey
Copy link
Contributor Author

shrey commented Jun 12, 2020

@cchaos they failed :( you know the reason?

@cchaos
Copy link
Contributor

cchaos commented Jun 12, 2020

It's because I pushed a commit changing the name of the test. We'll need to re-run the snapshots again. Though I'm currently working about a problem we seem to have with the styles and will end up pushing some style commits

@shrey
Copy link
Contributor Author

shrey commented Jun 12, 2020 •
edited
Loading

Oh alright, Do I need to update something? @cchaos

cchaos and others added 2 commits June 15, 2020 11:35
Fixing styles and snap
df3c27c 
- Removed visibility of scrollbar for toasts list
- Fixed padding for visibility of toast shadow
@cchaos
cl
3616ef7
@cchaos
Copy link
Contributor

cchaos commented Jun 15, 2020

Jenkins, test this

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_3600/

cchaos
cchaos approved these changes Jun 15, 2020
View reviewed changes
Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes all LGTM now 🎉

@cchaos cchaos merged commit c72a554 into elastic:master Jun 15, 2020
@shrey
Copy link
Contributor Author

shrey commented Jun 15, 2020

@cchaos :)

@thompsongl thompsongl mentioned this pull request Jun 29, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anishagg17 anishagg17 anishagg17 left review comments

@cchaos cchaos cchaos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

EuiGlobalToastList render it into Left side props (currently it's default rightside) ?
4 participants
@shrey @kibanamachine @anishagg17 @cchaos