Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Docs] filter_group_multi: update multi select example to be functional #4178

Merged
merged 5 commits into from
Oct 28, 2020
Merged

[Docs] filter_group_multi: update multi select example to be functional #4178

merged 5 commits into from
Oct 28, 2020

Conversation

Phizzard
Copy link
Contributor

@Phizzard Phizzard commented Oct 24, 2020 •
edited by cchaos
Loading

Summary

Fixes (partially) #4165

Updates Multi Select example with EuiFilterSelect and EuiFilterSelectGroup.

The list in the example has been updated to state so the example component can re-render as the item state updates. However, I noticed that it seems the EuiFilterSelectGroup doesn't re-render until you click off of the pop up containing the EuiFilterSelectItems.

Wondering if there's something missing from my updates or if it's something more underlying with the components?

Checklist

  • Check against all themes for compatibility in both light and dark modes
  • Checked in mobile
  • Checked in Chrome, Safari, Edge, and Firefox
  • Props have proper autodocs
  • Added documentation
  • Checked Code Sandbox works for the any docs examples
  • Added or updated jest tests
  • Checked for breaking changes and labeled appropriately
  • Checked for accessibility including keyboard-only and screenreader modes
  • A changelog entry exists and is marked appropriately

@kibanamachine
Copy link

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@thompsongl thompsongl self-requested a review October 26, 2020 15:12
@thompsongl
Copy link
Contributor

jenkins test this

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_4178/

thompsongl
thompsongl suggested changes Oct 26, 2020
View reviewed changes
Copy link
Contributor

@thompsongl thompsongl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @Phizzard!

A couple changes requested to make the example more consistent, but the basics are all there.

src-docs/src/views/filter_group/filter_group_multi.js Outdated Show resolved Hide resolved
src-docs/src/views/filter_group/filter_group_multi.js Outdated Show resolved Hide resolved
src-docs/src/views/filter_group/filter_group_multi.js Outdated Show resolved Hide resolved
@thompsongl thompsongl changed the title docs(filter_group_multi): update multi select example to be functional [Docs] filter_group_multi: update multi select example to be functional Oct 26, 2020
@Phizzard
Copy link
Contributor Author

Would it be cool if this PR could be labelled hacktoberfest-accepted to count towards Hacktoberfest once it's been approved? :)

@thompsongl
Copy link
Contributor

jenkins test this

cchaos
cchaos reviewed Oct 27, 2020
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_4178/

@cchaos
Copy link
Contributor

cchaos commented Oct 27, 2020

I would say that this only partially fixes #4165. It is updating the count of the checked = on items, but there are other UI elements that need to be hooked up like searching, loading, and no results.

Screen Shot 2020-10-27 at 11 29 29 AM

Screen Shot 2020-10-27 at 11 29 17 AM

That said, I'm totally fine merging this in as a partial fix. But wanted to open it up to the opportunity to hook it all up as a fully-working example.

@cchaos
Copy link
Contributor

cchaos commented Oct 28, 2020

Jenkins, test this

@cchaos cchaos requested a review from thompsongl October 28, 2020 15:21
@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_4178/

thompsongl
thompsongl approved these changes Oct 28, 2020
View reviewed changes
Copy link
Contributor

@thompsongl thompsongl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is in a good state, so I'll go ahead and merge it.

@Phizzard, if you're looking to make some more contributions, feel free to do a follow-up PR that address the other parts of this example that Caroline mentioned: search, loading, empty state.
Thanks again.

@thompsongl thompsongl merged commit 7524a5c into elastic:master Oct 28, 2020
@thompsongl thompsongl mentioned this pull request Oct 28, 2020
Closed
cchaos added a commit to andreadelrio/eui that referenced this pull request Nov 4, 2020
@Phizzard @cchaos
[Docs] filter_group_multi: update multi select example to be function…
90f0d8b 
…al (elastic#4178)

* docs(filter_group_multi): update multi select example to be functional

* fix(filter_group_multi): add working multi select example

* add elastic#4178 to changelog

* Remove extra space from cl

Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cchaos cchaos cchaos left review comments

@thompsongl thompsongl thompsongl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Phizzard @kibanamachine @thompsongl @cchaos