Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renamed euiPaletteNegtive and euiPalettePositive #4773

Closed
wants to merge 1 commit into from

Conversation

hetanthakkar
Copy link
Contributor

@hetanthakkar hetanthakkar commented Apr 30, 2021

Summary

Fixes issue #4766

Checklist

@kibanamachine
Copy link

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@hetanthakkar
Copy link
Contributor Author

@miukimiu I just renamed the euiPaletteNegtive and euiPalettePositive! Is my approach correct!?

@hetanthakkar hetanthakkar changed the title Renamed eiPaletteNegtive and eiPalettePositive Renamed euiPaletteNegtive and euiPalettePositive Apr 30, 2021
@hetanthakkar
Copy link
Contributor Author

@thompsongl What does this label mean!

@cchaos
Copy link
Contributor

cchaos commented Apr 30, 2021

@hetanthakkar1 We really appreciate your enthusiasm to help us out here, but I'm going to close this PR as it is a MAJOR breaking change and that issue is still under discussion (see the applied github labels). I'd stick to issues with the good-first-issue label as those should have well defined actions.

@cchaos cchaos closed this Apr 30, 2021
@cchaos
Copy link
Contributor

cchaos commented Apr 30, 2021

A breaking change means that all consumers who were using the euiPaletteNegative named exports would break their implementation with this name change. It's something we need to heavily consider as it impacts a lot of usages of EUI.

@hetanthakkar
Copy link
Contributor Author

@cchaos Got it thanks! Yeh this need serious attention!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants