Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove legacy theme #5688

Merged
merged 11 commits into from
Mar 10, 2022
Merged

Conversation

thompsongl
Copy link
Contributor

@thompsongl thompsongl commented Mar 3, 2022

Summary

Beginning the deprecation of the legacy theme.

  • Remove all references and features from the docs site
  • Remove compiled styles from dist/
  • Remove Legacy CSS-in-JS theme
  • Leave Sass for now because we need to restructure Amsterdam overrides

Checklist

  • Check against all themes for compatibility in both light and dark modes
  • Checked in Chrome, Safari, Edge, and Firefox
  • Checked Code Sandbox works for any docs examples
  • Checked for breaking changes and labeled appropriately
  • A changelog entry exists and is marked appropriately

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_5688/

@thompsongl thompsongl requested a review from cchaos March 8, 2022 14:53
@thompsongl thompsongl changed the title [WIP] Remove legacy theme from docs site [Docs] Remove legacy theme from docs site Mar 8, 2022
@thompsongl thompsongl marked this pull request as ready for review March 8, 2022 14:53
@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_5688/

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_5688/

Copy link
Contributor

@cchaos cchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed a few more removals and updated the Getting Started docs. It's all happening...

CHANGELOG.md Outdated Show resolved Hide resolved
src-docs/src/components/with_theme/theme_context.tsx Outdated Show resolved Hide resolved
@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_5688/

@thompsongl thompsongl changed the title [Docs] Remove legacy theme from docs site Remove legacy theme Mar 9, 2022
@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_5688/

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_5688/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants