-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade EUI to v52.2.0 #128841
Upgrade EUI to v52.2.0 #128841
Conversation
…pshots, and updated equality conditions for specific test cases
…ing for strict text equality to account for text coming from the EuiScreenReaderOnly component. Also updated tests to account for EuiIcon text that is now rendered when the icon is imported from .testenv (PR 5709 - elastic/eui#5709).
…apshots. Updated tests using getAllByLabelText and getByLabelText to getAllByText and getByText respectively as the former have been deprecated
…pshots. Updated instances of getByLabelText and getAllByLabelText to getByText and getAllByText as the former are now deprecated.
… Updated required snapshots. Updated various tests to account for text rendering of the EuiIcon text.
Pinging @elastic/apm-ui (Team:apm) |
Pinging @elastic/uptime (Team:uptime) |
Pinging @elastic/eui-design (EUI) |
- these changes should be reverted if we opt to revert the above PR
💛 Build succeeded, but was flakyTest Failures
Metrics [docs]Async chunks
Page load bundle
Unknown metric groupsESLint disabled in files
ESLint disabled line counts
References to deprecated APIs
Total ESLint disabled count
To update your PR or re-run it, just comment with: |
Thanks a lot for fixing this, @constancecchen @tylersmalley! |
Friendly reminder: Looks like this PR hasn’t been backported yet. |
NOTE
This PR is #128313, but with a11y failures in main addressed (73e12ce).
This will be admin merged by @tylersmalley without all CODEOWNER approvals when tests pass.
Summary
eui@51.1.0
⏩eui@52.2.0
EuiIcon
content including thearia-label
as text. This helps the automated a11y testing suite, but the EUI team is evaluating a different approach that would be less invasive. It's possible that these snapshot changes will be negated in the next release of EUI.52.2.0
branchUser
,desktop
andsessionViewer
glyphs toEuiIcon
(#5740)52.1.0
anchor
prop toEuiTourStep
to allow for DOM selector attachment (#5696)EuiDataGrid
now forcesisExpandable
to be true if anycellActions
are passed, as keyboard users are otherwise unable to access cell actions without the expansion popover (#5710)Bug fixes
EuiContextMenu
requiring two tab keypresses to advance to the next focusable menu item (#5719)EuiDataGrid
footer cell focus bugging out after moving its column (#5720)52.0.0
editorChecklist
glyph toEuiIcon
(#5705)testenv
mock forEuiIcon
to renderaria-label
as text (#5709)compressed
prop toEuiFilterGroup
and reduced the size of theEuiFilterButton
notification badge (#5717)EuiSelectableTemplateSitewide
input text when in dark header (#5724)Breaking changes
flush
andsize
props inEuiFilterButtonProps
(#5717)CSS-in-JS conversions
EuiMark
to CSS-in-JS styling (#4575)