-
Notifications
You must be signed in to change notification settings - Fork 843
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for expandable rows to EuiBasicTable. #585
Conversation
@elastic/kibana-design Could you spruce up the aesthetics of this feature after it's merged? |
Yep. Can do. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
I like the flexibility of using the @elastic/kibana-design what are your thoughts on using the This would also require additional styling to shrink the width of the first table column holding the expand / contract icons. Is this something that could be built into the out-the-box eui styles, or should it be left it to the implementation? |
@peteharverson Looking at @cjcenizal's example it looks like we can make it whatever we want. Likely we'll set the default example up with a caret system with a minimized column. Generally when these are done I think it's smart to (optionally) make the whole row clickable. I'd certainly recommend that for your example considering there's no links in that example beyond the expanding mechanic. We shouldn't limit people to such a small hitbox in that case. I can look into that as well when we get to styling it (soon after merge), but I think he's got the pieces we'd need. Nice work. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Fixes #466